Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments about interfaces #4405

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update comments about interfaces #4405

merged 2 commits into from
Jul 1, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 1, 2024 •
edited
Loading

Description

To make them more consistent.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jul 1, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.33%. Comparing base (fa0edad) to head (852a24a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4405      +/-   ##
==========================================
- Coverage   75.07%   70.33%   -4.74%     
==========================================
  Files         323      323              
  Lines       22398    22403       +5     
==========================================
- Hits        16815    15757    -1058     
- Misses       4385     5452    +1067     
+ Partials     1198     1194       -4
Files Coverage Δ
integration/shareddata/benchmark_provider.go 17.77% <ø> (ø)
integration/shareddata/provider.go 100.00% <ø> (ø)
internal/bson/raw_array.go 42.42% <ø> (ø)
internal/bson/raw_document.go 84.00% <ø> (ø)
internal/clientconn/connmetrics/conn_metrics.go 92.18% <ø> (ø)
...nternal/clientconn/connmetrics/listener_metrics.go 89.74% <ø> (ø)
internal/clientconn/cursor/registry.go 91.57% <ø> (ø)
internal/clientconn/listener.go 82.69% <100.00%> (+0.33%) ⬆️
internal/handler/handler.go 30.55% <ø> (-25.93%) ⬇️
internal/util/state/metrics.go 100.00% <ø> (ø)
... and 5 more

... and 57 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 63.40% <20.00%> (-6.76%) ⬇️
hana-1 ?
integration 63.40% <20.00%> (-6.88%) ⬇️
mongodb-1 5.05% <0.00%> (-0.02%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 43.94% <20.00%> (-11.09%) ⬇️
postgresql-2 44.99% <20.00%> (-8.68%) ⬇️
postgresql-3 43.02% <20.00%> (-9.68%) ⬇️
postgresql-4 40.26% <20.00%> (-0.06%) ⬇️
postgresql-5 ?
sqlite-1 43.14% <20.00%> (-10.88%) ⬇️
sqlite-2 44.02% <20.00%> (-8.66%) ⬇️
sqlite-3 42.22% <20.00%> (-9.39%) ⬇️
sqlite-4 39.41% <20.00%> (-0.01%) ⬇️
sqlite-5 ?
unit 33.04% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.23.0 milestone Jul 1, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 1, 2024
@AlekSi AlekSi marked this pull request as ready for review July 1, 2024 05:23
@AlekSi AlekSi requested a review from a team as a code owner July 1, 2024 05:23
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 1, 2024 05:23
@AlekSi AlekSi enabled auto-merge (squash) July 1, 2024 05:23
chilagrow
chilagrow approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi disabled auto-merge July 1, 2024 05:33
@AlekSi AlekSi merged commit ab00498 into FerretDB:main Jul 1, 2024
33 of 35 checks passed
@AlekSi AlekSi deleted the comments branch July 1, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow