Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated syntax in Dockerfiles #4397

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Replace deprecated syntax in Dockerfiles #4397

merged 1 commit into from
Jun 26, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 26, 2024 •
edited
Loading

Description

Avoid warnings on CI.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Jun 26, 2024
@AlekSi AlekSi added this to the v1.23.0 milestone Jun 26, 2024
@AlekSi AlekSi self-assigned this Jun 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (de509c5) to head (d2e0d5e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4397      +/-   ##
==========================================
- Coverage   74.31%   74.30%   -0.02%     
==========================================
  Files         323      323              
  Lines       22364    22364              
==========================================
- Hits        16620    16617       -3     
+ Misses       4563     4540      -23     
- Partials     1181     1207      +26

see 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.77% <ø> (-0.02%) ⬇️
hana-1 3.27% <ø> (+3.27%) ⬆️
integration 67.77% <ø> (-0.02%) ⬇️
mongodb-1 4.95% <ø> (-0.01%) ⬇️
postgresql-1 43.87% <ø> (-0.07%) ⬇️
postgresql-2 44.92% <ø> (+<0.01%) ⬆️
postgresql-3 42.96% <ø> (-0.09%) ⬇️
postgresql-4 40.30% <ø> (+0.03%) ⬆️
postgresql-5 43.65% <ø> (-0.43%) ⬇️
sqlite-1 43.07% <ø> (-0.06%) ⬇️
sqlite-2 44.02% <ø> (+0.03%) ⬆️
sqlite-3 42.19% <ø> (-0.15%) ⬇️
sqlite-4 39.36% <ø> (-0.01%) ⬇️
sqlite-5 43.03% <ø> (-0.02%) ⬇️
unit 33.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review June 26, 2024 15:09
@AlekSi AlekSi enabled auto-merge (squash) June 26, 2024 15:09
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup June 26, 2024 15:09
rumyantseva
rumyantseva approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit e1258e3 into FerretDB:main Jun 26, 2024
31 of 35 checks passed
@AlekSi AlekSi deleted the docker-env branch June 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup