Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port password changes #4388

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Port password changes #4388

merged 4 commits into from
Jun 25, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 25, 2024

Description

Closes #<issue_number>.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jun 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.07%. Comparing base (7c92996) to head (2744175).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4388   +/-   ##
=======================================
  Coverage   74.06%   74.07%           
=======================================
  Files         326      326           
  Lines       22356    22358    +2     
=======================================
+ Hits        16559    16562    +3     
+ Misses       4593     4592    -1     
  Partials     1204     1204
Files Coverage Δ
internal/handler/handler.go 54.16% <100.00%> (ø)
internal/handler/msg_createuser.go 75.22% <100.00%> (ø)
internal/util/password/scram.go 90.47% <100.00%> (ø)
internal/util/password/scramsha256.go 87.50% <100.00%> (ø)
internal/util/password/scramsha1.go 68.42% <75.00%> (ø)
internal/handler/msg_updateuser.go 64.75% <60.00%> (+0.75%) ⬆️
internal/util/password/password.go 66.66% <0.00%> (-33.34%) ⬇️
internal/handler/users/createuser.go 80.39% <58.33%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.46% <67.74%> (+<0.01%) ⬆️
hana-1 ?
integration 67.46% <67.74%> (+<0.01%) ⬆️
mongodb-1 4.95% <0.00%> (-0.01%) ⬇️
postgresql-1 44.00% <64.51%> (+0.07%) ⬆️
postgresql-2 44.86% <64.51%> (+0.06%) ⬆️
postgresql-3 42.95% <54.83%> (-0.03%) ⬇️
postgresql-4 40.28% <58.06%> (-0.01%) ⬇️
postgresql-5 43.66% <54.83%> (-0.05%) ⬇️
sqlite-1 43.09% <64.51%> (-0.06%) ⬇️
sqlite-2 43.89% <64.51%> (-0.09%) ⬇️
sqlite-3 42.19% <54.83%> (-0.02%) ⬇️
sqlite-4 39.41% <58.06%> (-0.05%) ⬇️
sqlite-5 42.98% <54.83%> (-0.04%) ⬇️
unit 33.14% <29.03%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.22.0 milestone Jun 25, 2024
@AlekSi AlekSi marked this pull request as ready for review June 25, 2024 14:46
@AlekSi AlekSi requested a review from a team as a code owner June 25, 2024 14:46
@AlekSi AlekSi requested review from rumyantseva and chilagrow June 25, 2024 14:46
@AlekSi AlekSi merged commit 748862f into FerretDB:main Jun 25, 2024
31 of 33 checks passed
@AlekSi AlekSi deleted the password branch June 25, 2024 14:46
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AlekSi