Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup OpenTelemetry exporter for FerretDB #4380

Merged
merged 38 commits into from
Jul 2, 2024
Merged

Setup OpenTelemetry exporter for FerretDB #4380

merged 38 commits into from
Jul 2, 2024

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Jun 21, 2024 •
edited by AlekSi
Loading

Description

Closes #4345.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Jun 21, 2024
@rumyantseva rumyantseva added not ready Issues that are not ready to be worked on; PRs that should skip CI code/chore Code maintenance improvements labels Jun 21, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.90%. Comparing base (bcb3ee1) to head (873dba7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4380      +/-   ##
==========================================
- Coverage   74.19%   73.90%   -0.29%     
==========================================
  Files         323      323              
  Lines       22419    22447      +28     
==========================================
- Hits        16634    16590      -44     
- Misses       4568     4635      +67     
- Partials     1217     1222       +5
Files Coverage Δ
integration/setup/startup.go 63.88% <83.33%> (+6.07%) ⬆️
internal/util/observability/observability.go 68.57% <57.69%> (-31.43%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.37% <65.78%> (-0.33%) ⬇️
hana-1 ?
integration 67.37% <65.78%> (-0.33%) ⬇️
mongodb-1 5.20% <65.78%> (+0.07%) ⬆️
postgresql-1 43.94% <65.78%> (+0.02%) ⬆️
postgresql-2 44.98% <65.78%> (+0.06%) ⬆️
postgresql-3 43.02% <65.78%> (+0.04%) ⬆️
postgresql-4 40.31% <65.78%> (+0.03%) ⬆️
postgresql-5 43.80% <65.78%> (+0.10%) ⬆️
sqlite-1 43.17% <65.78%> (+0.01%) ⬆️
sqlite-2 44.02% <65.78%> (-0.05%) ⬇️
sqlite-3 42.25% <65.78%> (+0.02%) ⬆️
sqlite-4 39.46% <65.78%> (+0.03%) ⬆️
sqlite-5 43.04% <65.78%> (+0.02%) ⬆️
unit 32.88% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.23.0 milestone Jun 24, 2024
@rumyantseva rumyantseva changed the title Setup Open Telemetry exporter for FerretDB Setup OpenTelemetry exporter for FerretDB Jun 25, 2024
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 25, 2024
@rumyantseva rumyantseva marked this pull request as ready for review June 25, 2024 07:45
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners June 25, 2024 07:45
@rumyantseva rumyantseva requested a review from chilagrow June 25, 2024 07:45
@rumyantseva rumyantseva enabled auto-merge (squash) June 25, 2024 07:45
@rumyantseva rumyantseva requested review from a team and noisersup June 25, 2024 07:45
AlekSi
AlekSi reviewed Jun 25, 2024
View reviewed changes
cmd/ferretdb/main.go Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Jun 25, 2024
View reviewed changes
cmd/ferretdb/main.go Outdated
@@ -125,6 +126,14 @@ var cli struct {
Package string `default:"" help:"Telemetry: custom package type."`
} `embed:"" prefix:"telemetry-"`
} `embed:"" prefix:"test-"`

OTEL struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be configurable with --test-XXX flags.

They should be under the Test group

AlekSi
AlekSi reviewed Jul 1, 2024
View reviewed changes
integration/setup/startup.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 1, 2024

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 1, 2024
@AlekSi
Merge branch 'main' into pr/rumyantseva/4380
1c0b1c9 
# Conflicts:
#	integration/setup/startup.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 1, 2024
@rumyantseva rumyantseva requested review from AlekSi and chilagrow July 1, 2024 16:33
@rumyantseva rumyantseva merged commit 79834b0 into FerretDB:main Jul 2, 2024
31 of 32 checks passed
@rumyantseva rumyantseva deleted the issue-4345-otel branch July 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Setup Otel exporter for FerretDB
4 participants
@rumyantseva @AlekSi @chilagrow @noisersup