Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes liveness probe #4378

Merged
merged 15 commits into from
Jun 27, 2024
Merged

Add Kubernetes liveness probe #4378

merged 15 commits into from
Jun 27, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 20, 2024 •
edited
Loading

Description

Closes #4306.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Jun 20, 2024
@noisersup noisersup changed the title Provide Kubernetes probes Add Kubernetes probes endpoints Jun 21, 2024
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Jun 21, 2024
@noisersup noisersup added this to the v1.22.0 milestone Jun 21, 2024
@noisersup noisersup changed the title Add Kubernetes probes endpoints Add Kubernetes probes stubs Jun 21, 2024
@noisersup noisersup marked this pull request as ready for review June 21, 2024 14:07
@noisersup noisersup requested a review from a team as a code owner June 21, 2024 14:07
@noisersup noisersup requested review from AlekSi and rumyantseva June 21, 2024 14:07
@noisersup noisersup enabled auto-merge (squash) June 21, 2024 14:07
@noisersup noisersup requested review from a team and chilagrow June 21, 2024 14:07
rumyantseva
rumyantseva previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the beginning!

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.91%. Comparing base (e1258e3) to head (53cdf28).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4378      +/-   ##
==========================================
- Coverage   73.94%   73.91%   -0.03%     
==========================================
  Files         323      323              
  Lines       22364    22398      +34     
==========================================
+ Hits        16537    16556      +19     
- Misses       4615     4623       +8     
- Partials     1212     1219       +7
Files Coverage Δ
internal/util/debug/debug.go 81.52% <73.52%> (-4.69%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.35% <73.52%> (-0.02%) ⬇️
hana-1 ?
integration 67.35% <73.52%> (-0.02%) ⬇️
mongodb-1 5.05% <73.52%> (+0.09%) ⬆️
postgresql-1 43.94% <73.52%> (+0.06%) ⬆️
postgresql-2 44.95% <73.52%> (-0.02%) ⬇️
postgresql-3 42.99% <73.52%> (+0.03%) ⬆️
postgresql-4 40.27% <73.52%> (+0.04%) ⬆️
postgresql-5 43.69% <73.52%> (+<0.01%) ⬆️
sqlite-1 43.12% <73.52%> (+0.01%) ⬆️
sqlite-2 ?
sqlite-3 42.22% <73.52%> (+0.07%) ⬆️
sqlite-4 39.42% <73.52%> (+0.05%) ⬆️
sqlite-5 43.04% <73.52%> (+<0.01%) ⬆️
unit 33.04% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup
Copy link
Member Author

@rumyantseva PTAL, I've removed one TODO comment, as I believe that's what we expect from liveness implementation.

@noisersup noisersup requested a review from rumyantseva June 21, 2024 14:13
rumyantseva
rumyantseva previously approved these changes Jun 21, 2024
View reviewed changes
internal/util/debug/debug.go Show resolved Hide resolved
chilagrow
chilagrow previously approved these changes Jun 24, 2024
View reviewed changes
@AlekSi AlekSi added the do not merge PRs that should not be merged label Jun 24, 2024
@AlekSi AlekSi modified the milestones: v1.22.0, v1.23.0 Jun 24, 2024
@noisersup noisersup dismissed stale reviews from chilagrow and rumyantseva via 6db982c June 26, 2024 12:37
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 26, 2024
rumyantseva
rumyantseva approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tried it locally :)
Looks good!

@noisersup noisersup merged commit 300fbc3 into FerretDB:main Jun 27, 2024
32 checks passed
@noisersup noisersup deleted the kubernetes-probe-endpoints-4306 branch June 27, 2024 04:30
@AlekSi AlekSi changed the title Add Kubernetes probes stubs Add Kubernetes liveness probe Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Provide Kubernetes probes
4 participants
@noisersup @AlekSi @rumyantseva @chilagrow