Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post on running FerretDB and CloudNativePG on Kubernetes #4377

Merged
merged 16 commits into from
Jun 28, 2024
Merged

Add blog post on running FerretDB and CloudNativePG on Kubernetes #4377

merged 16 commits into from
Jun 28, 2024

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Jun 20, 2024 •
edited
Loading

Description

Closes FerretDB/engineering#177

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the blog/marketing Marketing (and releases) blog posts label Jun 20, 2024
@Fashander Fashander added this to the v1.22.0 milestone Jun 20, 2024
@Fashander Fashander requested review from a team June 20, 2024 15:41
@Fashander Fashander self-assigned this Jun 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@mergify mergify bot requested review from AlekSi and ptrfarkas June 20, 2024 15:42
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.51%. Comparing base (ee7a8b1) to head (17a8902).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ee7a8b1) and HEAD (17a8902). Click for more details.

HEAD has 59 uploads less than BASE | Flag | BASE (ee7a8b1) | HEAD (17a8902) | |------|------|------| |integration|41|16| |filter-true|32|16| |sqlite-4|2|1| |sqlite-2|4|1| |postgresql-2|4|2| |postgresql-3|4|1| |sqlite-3|4|1| |sqlite-1|4|1| |postgresql-1|4|1| |sqlite-5|2|1| |postgresql-5|2|1| |mongodb-1|1|2| |unit|1|2|
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4377       +/-   ##
===========================================
- Coverage   74.95%   63.51%   -11.44%     
===========================================
  Files         323      323               
  Lines       22398    22398               
===========================================
- Hits        16788    14226     -2562     
- Misses       4399     6887     +2488     
- Partials     1211     1285       +74

see 102 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 55.05% <ø> (-15.07%) ⬇️
hana-1 0.00% <ø> (-3.39%) ⬇️
integration 55.05% <ø> (-15.11%) ⬇️
mongodb-1 5.05% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 21.84% <ø> (-33.19%) ⬇️
postgresql-2 44.96% <ø> (-8.65%) ⬇️
postgresql-3 24.44% <ø> (-28.12%) ⬇️
postgresql-4 40.27% <ø> (-0.01%) ⬇️
postgresql-5 20.21% <ø> (-23.56%) ⬇️
sqlite-1 21.29% <ø> (-32.71%) ⬇️
sqlite-2 22.98% <ø> (-29.69%) ⬇️
sqlite-3 23.84% <ø> (-27.74%) ⬇️
sqlite-4 21.66% <ø> (-17.76%) ⬇️
sqlite-5 19.53% <ø> (-23.49%) ⬇️
unit 33.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander marked this pull request as ready for review June 20, 2024 23:08
@Fashander Fashander enabled auto-merge (squash) June 20, 2024 23:08
@chilagrow chilagrow added trust PRs that can access Actions secrets not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 21, 2024
chilagrow
chilagrow reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the namespace consistency across the blog and test commands 🙏

website/blog/2024-06-20-run-ferretdb-cloudnativepg-kubernetes.md Outdated Show resolved Hide resolved
website/blog/2024-06-20-run-ferretdb-cloudnativepg-kubernetes.md Outdated Show resolved Hide resolved
@Fashander Fashander requested a review from chilagrow June 21, 2024 05:19
chilagrow
chilagrow reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fashander I think you've renamed something and few commands are not working, could you go over the entire doc and ensure commands work please 🤗

website/blog/2024-06-20-run-ferretdb-cloudnativepg-kubernetes.md Outdated Show resolved Hide resolved
website/blog/2024-06-20-run-ferretdb-cloudnativepg-kubernetes.md Outdated Show resolved Hide resolved
website/blog/2024-06-20-run-ferretdb-cloudnativepg-kubernetes.md Outdated Show resolved Hide resolved
@AlekSi AlekSi modified the milestones: v1.22.0, v1.23.0 Jun 24, 2024
@Fashander Fashander requested a review from rumyantseva June 25, 2024 21:17
chilagrow
chilagrow reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

chilagrow
chilagrow previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice post!

@AlekSi AlekSi added the do not merge PRs that should not be merged label Jun 28, 2024
AlekSi
AlekSi previously approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's bump the date.

@Fashander Fashander dismissed stale reviews from AlekSi and chilagrow via 17a8902 June 28, 2024 11:19
@Fashander Fashander requested review from AlekSi and chilagrow June 28, 2024 11:19
@Fashander
Copy link
Member Author

@AlekSi PTAL

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 28, 2024
@AlekSi AlekSi disabled auto-merge June 28, 2024 11:29
@AlekSi AlekSi merged commit fa0edad into FerretDB:main Jun 28, 2024
40 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@Fashander Fashander

Labels
blog/marketing Marketing (and releases) blog posts trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Fashander @AlekSi @rumyantseva @chilagrow