Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tools cache directory #4265

Merged
merged 1 commit into from
May 7, 2024
Merged

Move tools cache directory #4265

merged 1 commit into from
May 7, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 6, 2024 •
edited
Loading

Description

See #4258.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this May 6, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 6, 2024
@AlekSi AlekSi added this to the v1.22.0 milestone May 6, 2024
@AlekSi AlekSi changed the title Rename cache directory Move tools cache directory May 6, 2024
@AlekSi AlekSi marked this pull request as ready for review May 6, 2024 15:43
@AlekSi AlekSi enabled auto-merge (squash) May 6, 2024 15:43
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (f95b5d2) to head (33913f6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4265      +/-   ##
==========================================
- Coverage   75.35%   74.10%   -1.25%     
==========================================
  Files         323      323              
  Lines       22407    22407              
==========================================
- Hits        16884    16605     -279     
- Misses       4303     4586     +283     
+ Partials     1220     1216       -4

see 36 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.15% <ø> (-1.55%) ⬇️
hana-1 ?
integration 67.15% <ø> (-1.63%) ⬇️
mongodb-1 5.12% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 46.35% <ø> (-0.12%) ⬇️
postgresql-2 49.43% <ø> (-0.19%) ⬇️
postgresql-3 49.68% <ø> (-8.49%) ⬇️
sqlite-1 45.49% <ø> (-0.20%) ⬇️
sqlite-2 48.65% <ø> (-0.13%) ⬇️
sqlite-3 48.82% <ø> (-0.16%) ⬇️
unit 31.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request May 6, 2024
Merged
9 tasks
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup May 7, 2024 06:52
rumyantseva
rumyantseva approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 3903b99 into FerretDB:main May 7, 2024
30 of 34 checks passed
@AlekSi AlekSi deleted the move-cache branch May 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow