Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy setup flags #4247

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Add dummy setup flags #4247

merged 4 commits into from
Apr 19, 2024

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Apr 17, 2024

Description

Closes #4243.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the code/chore Code maintenance improvements label Apr 17, 2024
@b1ron b1ron self-assigned this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (60220be) to head (814b47b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4247      +/-   ##
==========================================
- Coverage   75.51%   73.97%   -1.55%     
==========================================
  Files         339      339              
  Lines       22910    22910              
==========================================
- Hits        17301    16948     -353     
- Misses       4289     4663     +374     
+ Partials     1320     1299      -21     

see 31 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.37% <ø> (-1.95%) ⬇️
hana-1 ?
integration 67.37% <ø> (-1.98%) ⬇️
mongodb-1 5.14% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 46.46% <ø> (-0.17%) ⬇️
postgresql-2 49.56% <ø> (-0.12%) ⬇️
postgresql-3 49.78% <ø> (-0.12%) ⬇️
sqlite-1 45.63% <ø> (-0.16%) ⬇️
sqlite-2 48.73% <ø> (-0.16%) ⬇️
sqlite-3 49.00% <ø> (-0.05%) ⬇️
unit 32.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron requested review from a team, rumyantseva, chilagrow, noisersup and AlekSi April 18, 2024 07:42
@AlekSi AlekSi marked this pull request as ready for review April 18, 2024 07:42
@AlekSi AlekSi requested a review from a team as a code owner April 18, 2024 07:42
@AlekSi AlekSi enabled auto-merge (squash) April 18, 2024 07:42
@AlekSi AlekSi added this to the v1.22.0 milestone Apr 18, 2024
@AlekSi AlekSi merged commit 2da27aa into FerretDB:main Apr 19, 2024
28 of 34 checks passed
@b1ron b1ron deleted the setup-flags branch April 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement ferretdb --setup flags
3 participants