Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct salt length #4126

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Use correct salt length #4126

merged 4 commits into from
Feb 27, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 27, 2024

Description

Legacy shell is picky about it.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Use correct salt length
43dc62c 
Legacy shell is picky about it.
@AlekSi AlekSi added this to the Next milestone Feb 27, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 27, 2024
@AlekSi AlekSi self-assigned this Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (35350b4) to head (0750e8e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4126      +/-   ##
==========================================
- Coverage   75.13%   74.05%   -1.09%     
==========================================
  Files         351      351              
  Lines       22473    22473              
==========================================
- Hits        16886    16642     -244     
- Misses       4275     4562     +287     
+ Partials     1312     1269      -43
Files Coverage Δ
internal/util/password/scramsha1.go 68.42% <ø> (ø)
internal/util/password/scramsha256.go 87.50% <ø> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.31% <ø> (-1.24%) ⬇️
hana-1 ?
integration 66.31% <ø> (-1.24%) ⬇️
mongodb-1 4.63% <ø> (ø)
postgresql-1 48.40% <ø> (+0.02%) ⬆️
postgresql-2 48.05% <ø> (+0.04%) ⬆️
postgresql-3 48.10% <ø> (+<0.01%) ⬆️
sqlite-1 47.57% <ø> (-0.02%) ⬇️
sqlite-2 47.29% <ø> (ø)
sqlite-3 ?
unit 32.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review February 27, 2024 06:49
@AlekSi AlekSi requested a review from a team as a code owner February 27, 2024 06:49
@AlekSi AlekSi enabled auto-merge (squash) February 27, 2024 06:50
@AlekSi AlekSi requested review from a team, henvic, noisersup and b1ron February 27, 2024 06:50
chilagrow
chilagrow approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for spotting this!

@AlekSi AlekSi merged commit 5eb9bde into FerretDB:main Feb 27, 2024
26 of 27 checks passed
@AlekSi AlekSi deleted the salt-length branch February 27, 2024 10:23
@b1ron b1ron mentioned this pull request Feb 27, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@b1ron b1ron Awaiting requested review from b1ron b1ron was automatically assigned from FerretDB/specops

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @chilagrow