Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fields to requests and responses #4096

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Add more fields to requests and responses #4096

merged 10 commits into from
Feb 20, 2024

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Feb 19, 2024 •
edited
Loading

Description

Closes #153.

In this PR, we only do the minimal changes needed for Compass UI to work.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Feb 19, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb8f0b2) 75.82% compared to head (eb25b42) 69.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4096      +/-   ##
==========================================
- Coverage   75.82%   69.36%   -6.46%     
==========================================
  Files         347      347              
  Lines       22195    22197       +2     
==========================================
- Hits        16829    15398    -1431     
- Misses       4037     5427    +1390     
- Partials     1329     1372      +43
Files Coverage Δ
internal/handler/common/delete_params.go 100.00% <ø> (ø)
internal/handler/common/find.go 100.00% <ø> (ø)
internal/handler/common/findandmodify.go 68.62% <ø> (-9.81%) ⬇️
internal/handler/common/insert.go 100.00% <ø> (ø)
internal/handler/common/ismaster.go 74.07% <100.00%> (+0.99%) ⬆️
internal/handler/common/update_params.go 100.00% <ø> (ø)
internal/wire/op_msg.go 61.17% <100.00%> (+0.20%) ⬆️

... and 79 files with indirect coverage changes

Flag Coverage Δ
filter-true 60.51% <50.00%> (-7.01%) ⬇️
hana-1 ?
integration 60.51% <50.00%> (-7.01%) ⬇️
mongodb-1 4.72% <0.00%> (?)
postgresql-1 ?
postgresql-2 46.86% <50.00%> (-0.03%) ⬇️
postgresql-3 47.22% <50.00%> (-0.01%) ⬇️
sqlite-1 ?
sqlite-2 45.99% <50.00%> (+0.03%) ⬆️
sqlite-3 46.44% <50.00%> (+<0.01%) ⬆️
unit 32.88% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title Add logicalSessionTimeoutMinutes to isMaster response Add sessions-related fields to requests and responses Feb 19, 2024
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Feb 19, 2024
@rumyantseva rumyantseva changed the title Add sessions-related fields to requests and responses Add more fields to requests and responses Feb 19, 2024
@rumyantseva rumyantseva added this to the Next milestone Feb 19, 2024
@rumyantseva rumyantseva marked this pull request as ready for review February 19, 2024 19:42
@rumyantseva rumyantseva requested a review from a team as a code owner February 19, 2024 19:42
@rumyantseva rumyantseva enabled auto-merge (squash) February 19, 2024 19:42
@rumyantseva rumyantseva requested review from a team, henvic and noisersup February 19, 2024 20:05
@rumyantseva rumyantseva mentioned this pull request Feb 20, 2024
Closed
9 tasks
@rumyantseva rumyantseva merged commit a1dc6c7 into FerretDB:main Feb 20, 2024
26 of 27 checks passed
@rumyantseva rumyantseva deleted the logicalSessionTimeoutMinutes branch February 20, 2024 07:36
@b1ron b1ron mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@henvic henvic henvic approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

Support session commands
3 participants
@rumyantseva @henvic @chilagrow