Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL backend collection #4083

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Add MySQL backend collection #4083

merged 16 commits into from
Feb 27, 2024

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Feb 15, 2024

Description

Closes #3413.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 312 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (81e0be8) to head (724470f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   76.19%   74.08%   -2.11%     
==========================================
  Files         349      351       +2     
  Lines       22170    22473     +303     
==========================================
- Hits        16893    16650     -243     
- Misses       3965     4556     +591     
+ Partials     1312     1267      -45     
Files Coverage Δ
internal/backends/mysql/mysql.go 0.00% <ø> (ø)
internal/backends/postgresql/query_iterator.go 86.88% <ø> (ø)
internal/backends/mysql/query_iterator.go 0.00% <0.00%> (ø)
internal/backends/mysql/insert.go 0.00% <0.00%> (ø)
internal/backends/mysql/helpers.go 0.00% <0.00%> (ø)
internal/backends/mysql/collection.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.43% <0.00%> (-2.17%) ⬇️
hana-1 ?
integration 66.43% <0.00%> (-2.17%) ⬇️
mongodb-1 4.63% <0.00%> (-0.07%) ⬇️
postgresql-1 48.40% <0.00%> (-0.67%) ⬇️
postgresql-2 48.00% <0.00%> (-0.75%) ⬇️
postgresql-3 48.10% <0.00%> (-0.67%) ⬇️
sqlite-1 47.57% <0.00%> (-0.64%) ⬇️
sqlite-2 47.26% <0.00%> (-0.59%) ⬇️
sqlite-3 47.27% <0.00%> (-0.65%) ⬇️
unit 32.69% <0.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Feb 16, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 16, 2024
@AlekSi AlekSi enabled auto-merge (squash) February 16, 2024 08:45
auto-merge was automatically disabled February 16, 2024 08:50

Head branch was pushed to by a user without write access

@adetunjii adetunjii requested a review from AlekSi February 16, 2024 08:50
@AlekSi AlekSi modified the milestones: v1.20.0, Next Feb 19, 2024
@AlekSi AlekSi enabled auto-merge (squash) February 21, 2024 10:14
AlekSi
AlekSi previously approved these changes Feb 21, 2024
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! See my comments 🤗

internal/backends/mysql/collection.go Outdated Show resolved Hide resolved
internal/backends/mysql/collection.go Show resolved Hide resolved
auto-merge was automatically disabled February 22, 2024 10:38

Head branch was pushed to by a user without write access

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL escaping will be fixed in another PR then 👍

@AlekSi AlekSi enabled auto-merge (squash) February 27, 2024 05:54
@AlekSi AlekSi merged commit 91ff095 into FerretDB:main Feb 27, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add MySQL backend
3 participants