Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce new authentication #4075

Merged
merged 52 commits into from
Feb 28, 2024
Merged

Enforce new authentication #4075

merged 52 commits into from
Feb 28, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Feb 14, 2024 •
edited
Loading

Description

Closes #1877.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Feb 14, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.21168% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 68.51%. Comparing base (ad05347) to head (fb4dd9e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4075      +/-   ##
==========================================
- Coverage   74.05%   68.51%   -5.54%     
==========================================
  Files         351      352       +1     
  Lines       22473    22579     +106     
==========================================
- Hits        16642    15470    -1172     
- Misses       4562     5743    +1181     
- Partials     1269     1366      +97
Files Coverage Δ
integration/setup/setup.go 81.25% <100.00%> (+1.86%) ⬆️
internal/clientconn/conninfo/conn_info.go 96.42% <100.00%> (+0.27%) ⬆️
internal/handler/commands.go 100.00% <100.00%> (ø)
internal/handler/msg_createuser.go 45.45% <100.00%> (-30.07%) ⬇️
internal/backends/postgresql/metadata/registry.go 70.67% <33.33%> (-0.70%) ⬇️
internal/handler/msg_saslstart.go 78.12% <37.50%> (-1.63%) ⬇️
internal/handler/authenticate.go 74.60% <74.60%> (ø)

... and 65 files with indirect coverage changes

Flag Coverage Δ
filter-true 60.28% <83.21%> (-6.12%) ⬇️
integration 60.28% <83.21%> (-6.12%) ⬇️
mongodb-1 4.63% <3.64%> (+<0.01%) ⬆️
postgresql-1 47.89% <80.29%> (-0.46%) ⬇️
postgresql-2 ?
postgresql-3 ?
sqlite-1 47.08% <79.56%> (-0.49%) ⬇️
sqlite-2 47.56% <66.42%> (+0.32%) ⬆️
sqlite-3 ?
unit 32.62% <28.22%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 15, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Feb 15, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Feb 16, 2024
@chilagrow chilagrow dismissed stale reviews from rumyantseva and henvic via 73ec82a February 21, 2024 10:07
henvic
henvic previously approved these changes Feb 21, 2024
View reviewed changes
rumyantseva
rumyantseva previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi requested review from a team February 27, 2024 07:41
@chilagrow chilagrow merged commit 910c351 into FerretDB:main Feb 28, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

Enforce new authentication
4 participants
@chilagrow @AlekSi @henvic @rumyantseva