Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement database.Stats for MySQL backend #4034

Merged
merged 15 commits into from
Feb 8, 2024
Merged

Implement database.Stats for MySQL backend #4034

merged 15 commits into from
Feb 8, 2024

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Feb 2, 2024 •
edited
Loading

Description

Closes #3413.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@adetunjii adetunjii requested a review from AlekSi as a code owner February 2, 2024 02:33
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (8213741) 75.12% compared to head (f74b0ac) 73.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4034      +/-   ##
==========================================
- Coverage   75.12%   73.66%   -1.46%     
==========================================
  Files         340      341       +1     
  Lines       27278    27423     +145     
==========================================
- Hits        20493    20202     -291     
- Misses       5489     5969     +480     
+ Partials     1296     1252      -44
Files Coverage Δ
internal/backends/mysql/mysql.go 0.00% <0.00%> (ø)
internal/backends/mysql/database.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-true 65.79% <0.00%> (-1.56%) ⬇️
hana-1 ?
integration 65.79% <0.00%> (-1.56%) ⬇️
mongodb-1 4.95% <0.00%> (-0.03%) ⬇️
postgresql-1 48.97% <0.00%> (-0.29%) ⬇️
postgresql-2 46.25% <0.00%> (-0.25%) ⬇️
postgresql-3 47.26% <0.00%> (-0.26%) ⬇️
sqlite-1 48.31% <0.00%> (-0.36%) ⬇️
sqlite-2 45.40% <0.00%> (-0.28%) ⬇️
sqlite-3 46.50% <0.00%> (-0.21%) ⬇️
unit 32.29% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 7, 2024
@AlekSi AlekSi added this to the Next milestone Feb 7, 2024
@AlekSi AlekSi enabled auto-merge (squash) February 7, 2024 10:57
@AlekSi AlekSi requested review from a team, henvic, rumyantseva, chilagrow and noisersup February 7, 2024 10:59
chilagrow
chilagrow approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🤗 Great work!

@AlekSi AlekSi merged commit fed2380 into FerretDB:main Feb 8, 2024
25 of 28 checks passed
henvic pushed a commit to henvic/FerretDB that referenced this pull request Feb 8, 2024
@adetunjii @henvic
Implement database.Stats for MySQL backend (FerretDB#4034)
41bec80 
Closes FerretDB#3413.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@henvic henvic Awaiting requested review from henvic henvic was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@adetunjii adetunjii

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

Add MySQL backend
3 participants
@adetunjii @AlekSi @chilagrow