Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps and speed-up checkcomments #4030

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Bump deps and speed-up checkcomments #4030

merged 6 commits into from
Feb 1, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 1, 2024 •
edited
Loading

Description

To be current and faster.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Feb 1, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1019078) 75.02% compared to head (55ef11c) 74.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
- Coverage   75.02%   74.03%   -1.00%     
==========================================
  Files         340      340              
  Lines       27298    27278      -20     
==========================================
- Hits        20480    20194     -286     
- Misses       5525     5830     +305     
+ Partials     1293     1254      -39
Files Coverage Δ
internal/backends/postgresql/collection.go 74.25% <ø> (ø)
...ernal/handler/common/aggregations/stages/unwind.go 83.00% <ø> (-0.17%) ⬇️
internal/handler/msg_createuser.go 70.27% <100.00%> (-0.40%) ⬇️
internal/handler/msg_dropuser.go 58.13% <100.00%> (-1.87%) ⬇️
internal/handler/msg_getmore.go 89.35% <ø> (+1.47%) ⬆️
internal/handler/msg_updateuser.go 61.78% <100.00%> (-2.29%) ⬇️
internal/handler/msg_usersinfo.go 71.95% <100.00%> (-0.59%) ⬇️

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.11% <100.00%> (-1.14%) ⬇️
hana-1 ?
integration 66.11% <100.00%> (-1.14%) ⬇️
mongodb-1 4.98% <0.00%> (+<0.01%) ⬆️
postgresql-1 49.38% <80.00%> (+0.09%) ⬆️
postgresql-2 46.49% <40.00%> (+<0.01%) ⬆️
postgresql-3 47.52% <60.00%> (-0.01%) ⬇️
sqlite-1 48.66% <80.00%> (-0.05%) ⬇️
sqlite-2 45.60% <40.00%> (-0.11%) ⬇️
sqlite-3 46.71% <60.00%> (-0.01%) ⬇️
unit 32.47% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Bump deps Bump deps and speed-up checkcomments Feb 1, 2024
@AlekSi AlekSi added this to the Next milestone Feb 1, 2024
@AlekSi AlekSi added deps PRs that update dependencies code/chore Code maintenance improvements labels Feb 1, 2024
@AlekSi AlekSi marked this pull request as ready for review February 1, 2024 08:34
@AlekSi AlekSi requested a review from a team as a code owner February 1, 2024 08:34
@AlekSi AlekSi enabled auto-merge (squash) February 1, 2024 08:34
@AlekSi AlekSi requested review from a team, henvic and noisersup February 1, 2024 08:34
chilagrow
chilagrow reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failing tailable cursor tests 🤔, could it be due to newer version of mongodb?

@AlekSi AlekSi requested review from chilagrow, henvic and a team February 1, 2024 10:00
@AlekSi AlekSi disabled auto-merge February 1, 2024 10:14
@AlekSi AlekSi merged commit fa7e262 into FerretDB:main Feb 1, 2024
31 of 33 checks passed
@AlekSi AlekSi deleted the deps branch February 1, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements deps PRs that update dependencies
Projects
Current Engineering
Archived in project
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @chilagrow