Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new authentication enabling flag #4029

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Expose new authentication enabling flag #4029

merged 2 commits into from
Feb 1, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 31, 2024

Description

The new authentication solution is not ready yet, but we started talking about it.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jan 31, 2024
@AlekSi AlekSi added this to the Next milestone Jan 31, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 31, 2024
@AlekSi AlekSi marked this pull request as ready for review January 31, 2024 17:33
@AlekSi AlekSi requested a review from a team as a code owner January 31, 2024 17:33
@AlekSi AlekSi enabled auto-merge (squash) January 31, 2024 17:33
@AlekSi AlekSi requested review from a team, henvic, noisersup and Fashander January 31, 2024 17:33
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f83c2e) 75.00% compared to head (761e85f) 74.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
- Coverage   75.00%   74.04%   -0.97%     
==========================================
  Files         340      340              
  Lines       27298    27298              
==========================================
- Hits        20476    20213     -263     
- Misses       5528     5830     +302     
+ Partials     1294     1255      -39     

see 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.13% <ø> (-1.11%) ⬇️
hana-1 ?
integration 66.13% <ø> (-1.11%) ⬇️
mongodb-1 4.98% <ø> (ø)
postgresql-1 49.29% <ø> (-0.10%) ⬇️
postgresql-2 46.49% <ø> (+0.03%) ⬆️
postgresql-3 47.52% <ø> (ø)
sqlite-1 48.57% <ø> (-0.02%) ⬇️
sqlite-2 45.66% <ø> (+0.04%) ⬆️
sqlite-3 46.71% <ø> (ø)
unit 32.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit 1019078 into FerretDB:main Feb 1, 2024
30 of 32 checks passed
@AlekSi AlekSi deleted the flag branch February 1, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants