Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bson2 helpers for conversions and logging #4019

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 29, 2024

Description

To simplify the transition from bson+types to bson2.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jan 29, 2024
@AlekSi AlekSi added this to the Next milestone Jan 29, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 29, 2024
@AlekSi AlekSi marked this pull request as ready for review January 29, 2024 16:26
@AlekSi AlekSi requested a review from a team as a code owner January 29, 2024 16:26
@AlekSi AlekSi enabled auto-merge (squash) January 29, 2024 16:26
@AlekSi AlekSi requested review from a team, henvic and noisersup January 29, 2024 16:26
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (83024e9) 75.39% compared to head (82543fd) 68.89%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
- Coverage   75.39%   68.89%   -6.50%     
==========================================
  Files         337      337              
  Lines       27157    27183      +26     
==========================================
- Hits        20474    18727    -1747     
- Misses       5389     7141    +1752     
- Partials     1294     1315      +21     
Files Coverage Δ
internal/bson2/slog.go 77.77% <0.00%> (-9.73%) ⬇️
internal/bson2/raw_array.go 30.76% <0.00%> (-10.62%) ⬇️
internal/bson2/raw_document.go 71.22% <0.00%> (-5.53%) ⬇️

... and 76 files with indirect coverage changes

Flag Coverage Δ
filter-true 62.93% <0.00%> (-7.31%) ⬇️
hana-1 ?
integration 62.93% <0.00%> (-7.31%) ⬇️
mongodb-1 5.19% <0.00%> (-0.01%) ⬇️
postgresql-1 ?
postgresql-2 48.52% <0.00%> (-0.05%) ⬇️
postgresql-3 49.59% <0.00%> (-0.06%) ⬇️
sqlite-1 ?
sqlite-2 47.62% <0.00%> (-0.08%) ⬇️
sqlite-3 48.79% <0.00%> (-0.01%) ⬇️
unit 32.59% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi merged commit 0d3eb76 into FerretDB:main Jan 30, 2024
25 of 27 checks passed
@AlekSi AlekSi deleted the bson2-logging branch January 30, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants