Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODO comments for logging #4015

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Add TODO comments for logging #4015

merged 3 commits into from
Jan 29, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 29, 2024

Description

Just add comments for future work.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 29, 2024
@AlekSi AlekSi added this to the Next milestone Jan 29, 2024
@AlekSi AlekSi self-assigned this Jan 29, 2024
@AlekSi AlekSi requested a review from a team as a code owner January 29, 2024 05:40
@AlekSi AlekSi enabled auto-merge (squash) January 29, 2024 05:40
@AlekSi AlekSi requested review from a team, henvic and noisersup January 29, 2024 05:41
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e685304) 75.48% compared to head (dfc3591) 74.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
- Coverage   75.48%   74.41%   -1.07%     
==========================================
  Files         337      337              
  Lines       27156    27157       +1     
==========================================
- Hits        20498    20209     -289     
- Misses       5370     5693     +323     
+ Partials     1288     1255      -33     
Files Coverage Δ
ferretdb/ferretdb.go 84.11% <ø> (ø)
internal/util/logging/logging.go 80.26% <100.00%> (+0.26%) ⬆️

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.07% <100.00%> (-1.20%) ⬇️
hana-1 ?
integration 69.07% <100.00%> (-1.20%) ⬇️
mongodb-1 5.20% <100.00%> (+<0.01%) ⬆️
postgresql-1 51.46% <100.00%> (-0.20%) ⬇️
postgresql-2 48.56% <100.00%> (-0.04%) ⬇️
postgresql-3 49.64% <100.00%> (+<0.01%) ⬆️
sqlite-1 50.88% <100.00%> (+<0.01%) ⬆️
sqlite-2 47.66% <100.00%> (-0.03%) ⬇️
sqlite-3 48.80% <100.00%> (+<0.01%) ⬆️
unit 32.62% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi modified the milestones: v1.19.0, Next Jan 29, 2024
@AlekSi AlekSi added do not merge PRs that should not be merged and removed do not merge PRs that should not be merged labels Jan 29, 2024
@AlekSi AlekSi merged commit 83024e9 into FerretDB:main Jan 29, 2024
26 of 28 checks passed
@AlekSi AlekSi deleted the todos branch January 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants