Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup MySQL backend #4003

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Setup MySQL backend #4003

merged 7 commits into from
Jan 31, 2024

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Jan 23, 2024 •
edited by AlekSi
Loading

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@adetunjii adetunjii requested a review from AlekSi as a code owner January 23, 2024 12:29
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: 117 lines in your changes are missing coverage. Please review.

Comparison is base (0d3eb76) 75.55% compared to head (103c711) 74.06%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
- Coverage   75.55%   74.06%   -1.49%     
==========================================
  Files         337      340       +3     
  Lines       27183    27298     +115     
==========================================
- Hits        20537    20218     -319     
- Misses       5364     5827     +463     
+ Partials     1282     1253      -29
Files Coverage Δ
internal/backends/mysql/backend.go 0.00% <0.00%> (-12.50%) ⬇️
internal/backends/mysql/database.go 0.00% <0.00%> (ø)
internal/backends/mysql/collection.go 0.00% <0.00%> (ø)
internal/backends/mysql/query_iterator.go 0.00% <0.00%> (ø)

... and 23 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 66.15% <0.00%> (-4.37%) ⬇️
hana-1 ?
integration 66.15% <0.00%> (-4.41%) ⬇️
mongodb-1 4.98% <0.00%> (-0.22%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 49.35% <0.00%> (-2.27%) ⬇️
postgresql-2 46.49% <0.00%> (-2.11%) ⬇️
postgresql-3 47.52% <0.00%> (-2.19%) ⬇️
sqlite-1 48.59% <0.00%> (-2.27%) ⬇️
sqlite-2 45.72% <0.00%> (-1.96%) ⬇️
sqlite-3 46.71% <0.00%> (-2.12%) ⬇️
unit 32.45% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi enabled auto-merge (squash) January 31, 2024 05:40
@AlekSi AlekSi added this to the Next milestone Jan 31, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 31, 2024
@AlekSi AlekSi requested review from a team, henvic, rumyantseva, chilagrow and noisersup January 31, 2024 05:41
chilagrow
chilagrow reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🤗! Please check the failing test.

@adetunjii
Copy link
Contributor Author

Great work 🤗! Please check the failing test.

@chilagrow I'm not sure what's causing that test to fail. I've not modified any code in that file, neither did I modify any code in relation to it.

AlekSi
AlekSi requested changes Jan 31, 2024
View reviewed changes
internal/backends/mysql/query_iterator.go Outdated Show resolved Hide resolved
AlekSi
AlekSi approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing import fixed CI

@AlekSi AlekSi requested a review from chilagrow January 31, 2024 08:00
chilagrow
chilagrow approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi merged commit de8e38d into FerretDB:main Jan 31, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@henvic henvic Awaiting requested review from henvic henvic was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@adetunjii adetunjii

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adetunjii @AlekSi @chilagrow