Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display envtool run test progress with run and/or skip flags #3999

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

fadyat
Copy link
Contributor

@fadyat fadyat commented Jan 22, 2024

Description

envtool tests run now display progress and the number of remaining tests when passing flags --run and/or --skip

Closes #3969.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@fadyat fadyat requested a review from a team as a code owner January 22, 2024 20:54
@fadyat fadyat requested review from AlekSi and rumyantseva January 22, 2024 20:54
@mergify mergify bot assigned fadyat Jan 22, 2024
@fadyat fadyat changed the title Display envtool run test progress with run and/or skip flags Display envtool run test progress with run and/or skip flags Jan 22, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa7e262) 75.27% compared to head (39960b0) 73.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3999      +/-   ##
==========================================
- Coverage   75.27%   73.94%   -1.33%     
==========================================
  Files         340      340              
  Lines       27278    27278              
==========================================
- Hits        20533    20172     -361     
- Misses       5465     5844     +379     
+ Partials     1280     1262      -18     

see 29 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 66.03% <ø> (-1.54%) ⬇️
hana-1 ?
integration 66.03% <ø> (-1.62%) ⬇️
mongodb-1 4.98% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 49.32% <ø> (-0.14%) ⬇️
postgresql-2 46.55% <ø> (-0.06%) ⬇️
postgresql-3 47.52% <ø> (-0.11%) ⬇️
sqlite-1 ?
sqlite-2 45.67% <ø> (-0.03%) ⬇️
sqlite-3 46.71% <ø> (-0.07%) ⬇️
unit 32.47% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi self-assigned this Jan 23, 2024
@noisersup noisersup self-requested a review January 29, 2024 10:50
@noisersup noisersup requested review from a team, henvic and chilagrow January 29, 2024 19:22
@noisersup noisersup added the code/chore Code maintenance improvements label Jan 29, 2024
@noisersup noisersup enabled auto-merge (squash) January 29, 2024 19:30
henvic
henvic previously approved these changes Jan 30, 2024
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, a tiny comment about adding documentation.

cmd/envtool/tests.go Show resolved Hide resolved
@AlekSi AlekSi mentioned this pull request Jan 31, 2024
9 tasks
@AlekSi AlekSi added this to the Next milestone Jan 31, 2024
auto-merge was automatically disabled January 31, 2024 14:25

Head branch was pushed to by a user without write access

@fadyat fadyat requested review from chilagrow and henvic January 31, 2024 14:25
@noisersup noisersup enabled auto-merge (squash) January 31, 2024 16:08
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks for your contribution 🤗

@noisersup noisersup merged commit 5536dac into FerretDB:main Feb 5, 2024
26 of 27 checks passed
@fadyat fadyat deleted the envtool-tests-meta-with-args branch February 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Process --run and --skip in the envtool itself
5 participants