Ignore $readPreference field
#3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ron
added
code/chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
==========================================
- Coverage 75.56% 74.54% -1.03%
==========================================
Files 337 337
Lines 27015 27015
==========================================
- Hits 20414 20138 -276
- Misses 5311 5621 +310
+ Partials 1290 1256 -34
... and 18 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
b1ron
changed the title
$readPreference field for Java driver$readPreference field
|
Auto-merge should be disabled and re-enabled for the new PR title to be propagated to the commit subject. |
AlekSi
reviewed
Jan 23, 2024
henvic
approved these changes
Jan 23, 2024
AlekSi
approved these changes
Jan 23, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some drivers will attach a
$readPreferencedocument when connecting to a replica set, see here and here for failures. We should ignore this field altogether.Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.