Fix validation process for creating duplicate _id index
#3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
+ Coverage 74.53% 74.59% +0.06%
==========================================
Files 337 337
Lines 27015 27015
==========================================
+ Hits 20136 20153 +17
+ Misses 5623 5610 -13
+ Partials 1256 1252 -4
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
suggested changes
Jan 19, 2024
rumyantseva
approved these changes
Jan 22, 2024
rumyantseva
changed the title
_id _id index
henvic
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align behavior of index creation commands for key:
_idto meet MongoDB requirements -those operations should not raiseIndex already exists with a different nameerror when key:_id(no matter if there isnamein the query).Closes #3921.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.