Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search queries #3976

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix search queries #3976

merged 2 commits into from
Jan 15, 2024

Conversation

Fashander
Copy link
Member

Description

Closes #2051.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Jan 15, 2024
@Fashander Fashander added this to the Next milestone Jan 15, 2024
@Fashander Fashander requested a review from a team January 15, 2024 12:53
@Fashander Fashander self-assigned this Jan 15, 2024
@Fashander Fashander added the trust PRs that can access Actions secrets label Jan 15, 2024
@Fashander Fashander enabled auto-merge (squash) January 15, 2024 12:53
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3eb9ee6) 74.61% compared to head (bb9e0be) 69.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
- Coverage   74.61%   69.13%   -5.48%     
==========================================
  Files         329      329              
  Lines       25881    25881              
==========================================
- Hits        19312    17894    -1418     
- Misses       5431     6767    +1336     
- Partials     1138     1220      +82

see 71 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 64.77% <ø> (-6.47%) ⬇️
hana-1 ?
integration 64.77% <ø> (-6.55%) ⬇️
mongodb-1 ?
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 ?
postgresql-2 50.51% <ø> (-0.12%) ⬇️
postgresql-3 ?
sqlite-1 ?
sqlite-2 ?
sqlite-3 52.04% <ø> (-0.25%) ⬇️
unit 30.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@AlekSi AlekSi disabled auto-merge January 15, 2024 15:42
@AlekSi AlekSi merged commit cb3d689 into FerretDB:main Jan 15, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@Fashander Fashander

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

Documentation search doesn't handle queries like $eq
3 participants
@Fashander @AlekSi @henvic