Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Taskfile.yml indentation #3964

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix Taskfile.yml indentation #3964

merged 1 commit into from
Jan 10, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 10, 2024 •
edited
Loading

Description

Makes require work.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Jan 10, 2024
@AlekSi AlekSi added this to the Next milestone Jan 10, 2024
@AlekSi AlekSi self-assigned this Jan 10, 2024
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jan 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8edda55) 74.18% compared to head (42f1196) 74.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3964      +/-   ##
==========================================
- Coverage   74.18%   74.05%   -0.14%     
==========================================
  Files         330      330              
  Lines       25943    25943              
==========================================
- Hits        19246    19211      -35     
- Misses       5561     5591      +30     
- Partials     1136     1141       +5

see 10 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 70.67% <ø> (-0.30%) ⬇️
hana-1 ∅ <ø> (∅)
integration 70.67% <ø> (-0.32%) ⬇️
mongodb-1 5.17% <ø> (ø)
mysql-1 ?
postgresql-1 49.66% <ø> (-13.93%) ⬇️
postgresql-2 52.19% <ø> (+0.02%) ⬆️
postgresql-3 50.94% <ø> (ø)
sqlite-1 48.79% <ø> (-12.70%) ⬇️
sqlite-2 51.24% <ø> (-0.06%) ⬇️
sqlite-3 50.03% <ø> (+0.03%) ⬆️
unit 30.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review January 10, 2024 09:03
@AlekSi AlekSi merged commit 53b7e4d into FerretDB:main Jan 10, 2024
44 of 58 checks passed
@AlekSi AlekSi deleted the fix-taskfile branch January 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AlekSi