Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /debug/archive handler #3895

Merged
merged 91 commits into from
Jul 23, 2024

Conversation

sachinpuranik
Copy link
Contributor

@sachinpuranik sachinpuranik commented Dec 21, 2023

Closes #3584.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@sachinpuranik sachinpuranik requested review from AlekSi and a team as code owners December 21, 2023 07:55
@sachinpuranik sachinpuranik changed the title Implement "/debug/archive" handler - #3584 Implement "/debug/archive" handler Dec 21, 2023
@AlekSi AlekSi added this to the Next milestone Dec 21, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 21, 2023
@AlekSi AlekSi enabled auto-merge (squash) December 21, 2023 15:03
@AlekSi AlekSi changed the title Implement "/debug/archive" handler Implement /debug/archive handler Dec 21, 2023
@AlekSi AlekSi disabled auto-merge December 21, 2023 15:04
@AlekSi AlekSi enabled auto-merge (squash) December 21, 2023 15:04
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 63.79310% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (3f1e013) to head (5ebd054).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3895      +/-   ##
==========================================
- Coverage   73.68%   73.65%   -0.04%     
==========================================
  Files         330      330              
  Lines       22811    22858      +47     
==========================================
+ Hits        16809    16835      +26     
- Misses       4764     4778      +14     
- Partials     1238     1245       +7     
Files Coverage Δ
internal/util/debug/debug.go 74.21% <63.79%> (-7.93%) ⬇️

... and 2 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.78% <20.68%> (-0.14%) ⬇️
hana-1 ?
integration 66.78% <20.68%> (-0.14%) ⬇️
mongodb-1 5.39% <20.68%> (-0.01%) ⬇️
postgresql-1 42.58% <20.68%> (-0.09%) ⬇️
postgresql-2 42.49% <20.68%> (-0.12%) ⬇️
postgresql-3 42.31% <20.68%> (-0.06%) ⬇️
postgresql-4 43.98% <20.68%> (-0.02%) ⬇️
postgresql-5 45.30% <20.68%> (-0.10%) ⬇️
sqlite-1 41.49% <20.68%> (-0.10%) ⬇️
sqlite-2 41.58% <20.68%> (-0.09%) ⬇️
sqlite-3 41.30% <20.68%> (-0.10%) ⬇️
sqlite-4 23.29% <20.68%> (-19.57%) ⬇️
sqlite-5 44.29% <20.68%> (-0.12%) ⬇️
unit 33.51% <63.79%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug.go Outdated Show resolved Hide resolved
internal/util/debug/debug_test.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled December 21, 2023 16:53

Head branch was pushed to by a user without write access

@noisersup noisersup requested review from noisersup and AlekSi July 19, 2024 13:04
@chilagrow
Copy link
Member

That code should use slog, not zap

@noisersup this comment was missed.

Copy link
Contributor

mergify bot commented Jul 22, 2024

@sachinpuranik this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 22, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 22, 2024
@noisersup noisersup requested a review from chilagrow July 22, 2024 12:01
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, asked a couple of questions for my understanding.

internal/util/debug/debug.go Show resolved Hide resolved
internal/util/debug/debug.go Show resolved Hide resolved
@noisersup noisersup merged commit 9798401 into FerretDB:main Jul 23, 2024
31 of 32 checks passed
@AlekSi AlekSi removed the community Issues and PRs assigned to community members label Jul 23, 2024
@AlekSi AlekSi added the community Issues and PRs assigned to community members label Jul 23, 2024
@AlekSi
Copy link
Member

AlekSi commented Jul 23, 2024

@sachinpuranik Thank you for your contribution! and sorry it took us so long 😬

@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/chore Code maintenance improvements labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet community Issues and PRs assigned to community members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement /debug/archive
6 participants