Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more cursor tests #3893

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Add more cursor tests #3893

merged 5 commits into from
Dec 21, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Dec 20, 2023 •
edited
Loading

Description

Closes #3739.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5e44a7) 72.50% compared to head (05009bd) 75.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3893      +/-   ##
==========================================
+ Coverage   72.50%   75.37%   +2.86%     
==========================================
  Files         312      325      +13     
  Lines       23873    24873    +1000     
==========================================
+ Hits        17309    18747    +1438     
+ Misses       5449     5003     -446     
- Partials     1115     1123       +8

see 101 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.39% <ø> (-0.12%) ⬇️
hana-1 ?
integration 72.39% <ø> (-0.12%) ⬇️
mongodb-1 5.23% <ø> (ø)
postgresql-1 50.48% <ø> (-0.49%) ⬇️
postgresql-2 51.86% <ø> (-1.39%) ⬇️
postgresql-3 53.39% <ø> (+1.21%) ⬆️
sqlite-1 49.59% <ø> (-0.67%) ⬇️
sqlite-2 50.97% <ø> (-1.33%) ⬇️
sqlite-3 52.53% <ø> (+1.22%) ⬆️
unit 31.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review December 21, 2023 11:30
@noisersup noisersup requested a review from a team as a code owner December 21, 2023 11:30
@noisersup noisersup added the code/chore Code maintenance improvements label Dec 21, 2023
@noisersup noisersup requested review from a team and henvic December 21, 2023 11:31
@noisersup noisersup added this to the Next milestone Dec 21, 2023
@noisersup noisersup enabled auto-merge (squash) December 21, 2023 11:31
This was referenced Dec 21, 2023
Closed
Closed
@AlekSi AlekSi disabled auto-merge December 21, 2023 15:02
@AlekSi AlekSi merged commit b9eafc5 into FerretDB:main Dec 21, 2023
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Investigate CursorNotFound error
3 participants
@noisersup @AlekSi @henvic