Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dropUser command #3866

Merged
merged 19 commits into from
Dec 20, 2023
Merged

Implement dropUser command #3866

merged 19 commits into from
Dec 20, 2023

Conversation

henvic
Copy link
Contributor

@henvic henvic commented Dec 18, 2023 •
edited
Loading

Description

Implement dropUser command.

Closes #1493.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@henvic henvic added the code/feature Some user-visible feature is not implemented yet label Dec 18, 2023
@henvic henvic added this to the Next milestone Dec 18, 2023
@henvic henvic self-assigned this Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6a29fa9) 75.43% compared to head (813b2f4) 75.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3866      +/-   ##
==========================================
- Coverage   75.43%   75.33%   -0.10%     
==========================================
  Files         324      324              
  Lines       24724    24763      +39     
==========================================
+ Hits        18651    18656       +5     
- Misses       4969     4995      +26     
- Partials     1104     1112       +8
Files Coverage Δ
internal/handler/handlererrors/error.go 88.23% <ø> (ø)
internal/handler/handlererrors/errorcode_string.go 80.00% <ø> (ø)
internal/handler/msg_dropuser.go 60.00% <62.50%> (+60.00%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.33% <62.50%> (-0.10%) ⬇️
hana-1 ?
integration 72.33% <62.50%> (-0.10%) ⬇️
mongodb-1 5.24% <0.00%> (-0.01%) ⬇️
postgresql-1 51.42% <62.50%> (-0.96%) ⬇️
postgresql-2 52.53% <0.00%> (+1.72%) ⬆️
postgresql-3 52.72% <0.00%> (-0.80%) ⬇️
sqlite-1 50.75% <62.50%> (-0.90%) ⬇️
sqlite-2 51.65% <0.00%> (+1.82%) ⬆️
sqlite-3 51.80% <0.00%> (-0.81%) ⬇️
unit 31.22% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

@henvic this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Dec 19, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Dec 19, 2023
@henvic henvic marked this pull request as ready for review December 19, 2023 12:12
@henvic henvic requested a review from a team as a code owner December 19, 2023 12:12
@henvic henvic requested review from AlekSi and rumyantseva December 19, 2023 12:12
@henvic henvic enabled auto-merge (squash) December 19, 2023 12:12
@henvic henvic requested review from a team and noisersup December 19, 2023 12:14
AlekSi
AlekSi previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

integration/users/drop_user_test.go Outdated Show resolved Hide resolved
integration/users/drop_user_test.go Outdated Show resolved Hide resolved
integration/users/drop_user_test.go Outdated Show resolved Hide resolved
@henvic henvic requested a review from AlekSi December 19, 2023 15:29
AlekSi
AlekSi reviewed Dec 19, 2023
View reviewed changes
integration/users/drop_user_test.go Outdated Show resolved Hide resolved
integration/users/drop_user_test.go Show resolved Hide resolved
noisersup
noisersup previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henvic henvic requested review from noisersup and AlekSi December 19, 2023 16:32
@AlekSi AlekSi changed the title Implement dropUser command Implement dropUser command Dec 20, 2023
@AlekSi AlekSi disabled auto-merge December 20, 2023 03:38
@AlekSi AlekSi enabled auto-merge (squash) December 20, 2023 03:38
@AlekSi AlekSi merged commit eefeb0d into FerretDB:main Dec 20, 2023
32 checks passed
@b1ron b1ron mentioned this pull request Jan 1, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@henvic henvic

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Implement dropUser command
3 participants
@henvic @AlekSi @noisersup