Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing logging parameter #3847

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Add missing logging parameter #3847

merged 2 commits into from
Dec 14, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 13, 2023 •
edited
Loading

Description

Fixes %!v(MISSING) in logs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Dec 13, 2023
@AlekSi AlekSi added this to the Next milestone Dec 13, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 13, 2023
@AlekSi AlekSi marked this pull request as ready for review December 13, 2023 07:29
@AlekSi AlekSi requested a review from a team as a code owner December 13, 2023 07:29
@AlekSi AlekSi requested a review from rumyantseva December 13, 2023 07:29
@AlekSi AlekSi enabled auto-merge (squash) December 13, 2023 07:29
@AlekSi AlekSi requested review from a team, henvic and noisersup December 13, 2023 07:30
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Merging #3847 (b967c01) into main (c020139) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3847      +/-   ##
==========================================
- Coverage   76.32%   76.21%   -0.11%     
==========================================
  Files         317      317              
  Lines       23729    23729              
==========================================
- Hits        18111    18085      -26     
- Misses       4572     4594      +22     
- Partials     1046     1050       +4
Files Coverage Δ
internal/handler/msg_find.go 77.24% <100.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.35% <100.00%> (-0.12%) ⬇️
hana-1 ?
integration 72.35% <100.00%> (-0.12%) ⬇️
mongodb-1 5.34% <0.00%> (-0.02%) ⬇️
postgresql-1 51.25% <100.00%> (ø)
postgresql-2 53.56% <100.00%> (ø)
postgresql-3 51.32% <100.00%> (ø)
sqlite-1 ?
sqlite-2 52.62% <100.00%> (ø)
sqlite-3 50.57% <100.00%> (-0.03%) ⬇️
unit 30.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit c4b84a3 into FerretDB:main Dec 14, 2023
27 of 28 checks passed
@AlekSi AlekSi deleted the fix-log-statement branch December 14, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@henvic henvic henvic approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @henvic @rumyantseva @noisersup