Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up tests a bit #3835

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Clean-up tests a bit #3835

merged 3 commits into from
Dec 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 11, 2023 •
edited
Loading

Description

To make future PRs smaller.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Dec 11, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 11, 2023
@AlekSi AlekSi self-assigned this Dec 11, 2023
@AlekSi AlekSi marked this pull request as ready for review December 11, 2023 16:49
@AlekSi AlekSi requested a review from a team as a code owner December 11, 2023 16:49
@AlekSi AlekSi requested a review from rumyantseva December 11, 2023 16:49
@AlekSi AlekSi enabled auto-merge (squash) December 11, 2023 16:49
@AlekSi AlekSi requested review from a team, henvic and noisersup December 11, 2023 16:49
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Merging #3835 (b8832f7) into main (008b88e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3835      +/-   ##
==========================================
- Coverage   76.29%   76.22%   -0.08%     
==========================================
  Files         316      316              
  Lines       23662    23666       +4     
==========================================
- Hits        18054    18040      -14     
- Misses       4564     4581      +17     
- Partials     1044     1045       +1
Files Coverage Δ
...nternal/util/iterator/testiterator/testiterator.go 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.35% <ø> (-0.11%) ⬇️
hana-1 ?
integration 72.35% <ø> (-0.11%) ⬇️
mongodb-1 5.18% <ø> (ø)
postgresql-1 51.95% <ø> (+0.02%) ⬆️
postgresql-2 51.58% <ø> (-0.73%) ⬇️
postgresql-3 53.03% <ø> (+0.90%) ⬆️
sqlite-1 51.08% <ø> (-0.17%) ⬇️
sqlite-2 50.65% <ø> (-0.73%) ⬇️
sqlite-3 52.24% <ø> (+0.95%) ⬆️
unit 30.68% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

henvic
henvic previously approved these changes Dec 11, 2023
View reviewed changes
@AlekSi AlekSi disabled auto-merge December 11, 2023 17:25
@AlekSi AlekSi merged commit 6737d32 into FerretDB:main Dec 11, 2023
29 checks passed
@AlekSi AlekSi deleted the tests branch December 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @henvic