Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract find helper functions #3826

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Extract find helper functions #3826

merged 1 commit into from
Dec 7, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 7, 2023 •
edited
Loading

Description

Needed to reduce merge conflicts down the road.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 7, 2023
@AlekSi AlekSi added this to the Next milestone Dec 7, 2023
@AlekSi AlekSi self-assigned this Dec 7, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Merging #3826 (7909dd8) into main (c04dfb2) will decrease coverage by 0.04%.
The diff coverage is 82.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3826      +/-   ##
==========================================
- Coverage   76.28%   76.24%   -0.04%     
==========================================
  Files         316      316              
  Lines       23586    23600      +14     
==========================================
+ Hits        17992    17994       +2     
- Misses       4549     4562      +13     
+ Partials     1045     1044       -1
Files Coverage Δ
internal/handler/msg_find.go 79.21% <82.81%> (-0.67%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.38% <82.81%> (-0.04%) ⬇️
hana-1 ?
integration 72.38% <82.81%> (-0.04%) ⬇️
mongodb-1 5.19% <0.00%> (-0.01%) ⬇️
postgresql-1 52.43% <78.12%> (+0.02%) ⬆️
postgresql-2 51.22% <65.62%> (-0.16%) ⬇️
postgresql-3 52.59% <54.68%> (+<0.01%) ⬆️
sqlite-1 51.60% <78.12%> (+0.06%) ⬆️
sqlite-2 50.63% <65.62%> (+0.01%) ⬆️
sqlite-3 51.75% <54.68%> (+0.01%) ⬆️
unit 30.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review December 7, 2023 08:47
@AlekSi AlekSi requested a review from a team as a code owner December 7, 2023 08:47
@AlekSi AlekSi requested a review from rumyantseva December 7, 2023 08:47
@AlekSi AlekSi enabled auto-merge (squash) December 7, 2023 08:47
@AlekSi AlekSi requested review from a team, henvic and noisersup December 7, 2023 08:47
noisersup
noisersup approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with extracting that. I think we'll need to do the same for explain and aggregate.

internal/backends/backends.go Show resolved Hide resolved
@AlekSi
Copy link
Member Author

AlekSi commented Dec 7, 2023

I think we'll need to do the same for explain and aggregate.

Let's not do that just yet. I did it for find because those pieces we will use in getMore implementation for tailable cursors

@AlekSi AlekSi disabled auto-merge December 7, 2023 10:18
@AlekSi AlekSi merged commit fe268cb into FerretDB:main Dec 7, 2023
30 of 32 checks passed
@AlekSi AlekSi deleted the make-iter branch December 7, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@henvic henvic Awaiting requested review from henvic henvic was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @noisersup