Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subdirectories for integration tests #3810

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Support subdirectories for integration tests #3810

merged 2 commits into from
Dec 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 5, 2023 •
edited
Loading

Description

That's an experiment and does not change our existing naming scheme yet.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 5, 2023
@mergify mergify bot assigned AlekSi Dec 5, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Dec 5, 2023
@AlekSi AlekSi added this to the Next milestone Dec 5, 2023
@AlekSi AlekSi marked this pull request as ready for review December 5, 2023 12:17
@AlekSi AlekSi requested a review from a team as a code owner December 5, 2023 12:17
@AlekSi AlekSi requested a review from rumyantseva December 5, 2023 12:17
@AlekSi AlekSi enabled auto-merge (squash) December 5, 2023 12:17
@AlekSi AlekSi requested review from a team, henvic and noisersup December 5, 2023 12:17
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Merging #3810 (396b20d) into main (7aefd7d) will decrease coverage by 0.32%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   76.57%   76.25%   -0.32%     
==========================================
  Files         315      315              
  Lines       23540    23556      +16     
==========================================
- Hits        18025    17963      -62     
- Misses       4473     4549      +76     
- Partials     1042     1044       +2
Files Coverage Δ
integration/integration.go 87.75% <100.00%> (ø)
integration/setup/helpers.go 100.00% <100.00%> (ø)
integration/setup/listener.go 71.12% <100.00%> (-7.69%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
internal/handler/registry/registry.go 43.47% <ø> (ø)
internal/clientconn/listener.go 81.21% <30.76%> (+0.59%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.38% <63.33%> (-0.31%) ⬇️
hana-1 ?
integration 72.38% <63.33%> (-0.34%) ⬇️
mongodb-1 5.19% <3.33%> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 52.43% <63.33%> (+0.02%) ⬆️
postgresql-2 51.30% <63.33%> (-0.05%) ⬇️
postgresql-3 52.99% <63.33%> (-0.03%) ⬇️
sqlite-1 51.39% <63.33%> (-0.07%) ⬇️
sqlite-2 50.44% <63.33%> (-0.01%) ⬇️
sqlite-3 52.05% <63.33%> (-0.09%) ⬇️
unit 30.75% <30.76%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

noisersup
noisersup approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll be helpful. Especially with diff tests

rumyantseva
rumyantseva approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 4e47318 into FerretDB:main Dec 5, 2023
45 of 48 checks passed
@AlekSi AlekSi deleted the cursors-tests branch December 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@henvic henvic Awaiting requested review from henvic henvic was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup