Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log batches for find, aggregate, getMore #3800

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Log batches for find, aggregate, getMore #3800

merged 2 commits into from
Dec 3, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 1, 2023 •
edited
Loading

Description

Plus a few small cleanups.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #3800 (d013452) into main (71bae17) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3800      +/-   ##
==========================================
- Coverage   76.32%   76.25%   -0.08%     
==========================================
  Files         315      315              
  Lines       23506    23520      +14     
==========================================
- Hits        17941    17935       -6     
- Misses       4523     4542      +19     
- Partials     1042     1043       +1
Files Coverage Δ
internal/backends/postgresql/query_iterator.go 87.80% <ø> (ø)
internal/backends/sqlite/query_iterator.go 82.92% <ø> (ø)
internal/clientconn/cursor/cursor.go 100.00% <100.00%> (ø)
internal/clientconn/cursor/registry.go 91.66% <100.00%> (ø)
...ernal/handler/common/aggregations/stages/unwind.go 83.16% <100.00%> (ø)
internal/handler/common/sort_iterator.go 100.00% <100.00%> (ø)
internal/handler/msg_aggregate.go 87.96% <100.00%> (+0.13%) ⬆️
internal/handler/msg_find.go 79.37% <100.00%> (+0.39%) ⬆️
internal/handler/msg_getmore.go 92.90% <100.00%> (+0.09%) ⬆️
internal/util/resource/resource.go 66.10% <ø> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.40% <100.00%> (-0.07%) ⬇️
hana-1 ?
integration 72.40% <100.00%> (-0.07%) ⬇️
mongodb-1 5.35% <0.00%> (-0.01%) ⬇️
postgresql-1 51.41% <88.88%> (+0.05%) ⬆️
postgresql-2 52.84% <97.22%> (+0.18%) ⬆️
postgresql-3 52.19% <91.66%> (+0.04%) ⬆️
sqlite-1 50.65% <88.88%> (+0.05%) ⬆️
sqlite-2 51.89% <97.22%> (-0.03%) ⬇️
sqlite-3 51.28% <91.66%> (-0.02%) ⬇️
unit 30.71% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Dec 1, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 1, 2023
@AlekSi AlekSi marked this pull request as ready for review December 1, 2023 12:50
@AlekSi AlekSi requested a review from a team as a code owner December 1, 2023 12:50
@AlekSi AlekSi requested a review from rumyantseva December 1, 2023 12:50
@AlekSi AlekSi enabled auto-merge (squash) December 1, 2023 12:50
@AlekSi AlekSi requested review from a team, henvic and noisersup December 1, 2023 12:51
noisersup
noisersup approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge December 3, 2023 18:39
@AlekSi AlekSi merged commit ced8ce0 into FerretDB:main Dec 3, 2023
29 checks passed
@AlekSi AlekSi deleted the log-batche branch December 3, 2023 18:39
@b1ron b1ron mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @noisersup