Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore go-consistent failures #3794

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Ignore go-consistent failures #3794

merged 3 commits into from
Dec 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 1, 2023 •
edited
Loading

Description

Temporary workaround for CI failures that prevent auto-merges.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Dec 1, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 1, 2023
@mergify mergify bot assigned AlekSi Dec 1, 2023
@AlekSi AlekSi marked this pull request as ready for review December 1, 2023 05:25
@AlekSi AlekSi requested a review from a team as a code owner December 1, 2023 05:25
@AlekSi AlekSi requested a review from rumyantseva December 1, 2023 05:25
@AlekSi AlekSi enabled auto-merge (squash) December 1, 2023 05:25
@AlekSi AlekSi requested review from a team, henvic and noisersup December 1, 2023 05:25
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #3794 (78a8c90) into main (c127482) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   76.33%   76.23%   -0.11%     
==========================================
  Files         315      315              
  Lines       23506    23506              
==========================================
- Hits        17944    17920      -24     
- Misses       4520     4541      +21     
- Partials     1042     1045       +3

see 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.38% <ø> (-0.11%) ⬇️
hana-1 ?
integration 72.38% <ø> (-0.11%) ⬇️
mongodb-1 5.36% <ø> (ø)
postgresql-1 51.36% <ø> (ø)
postgresql-2 52.65% <ø> (-0.16%) ⬇️
postgresql-3 52.20% <ø> (+0.05%) ⬆️
sqlite-1 50.60% <ø> (ø)
sqlite-2 51.91% <ø> (+0.11%) ⬆️
sqlite-3 51.20% <ø> (-0.01%) ⬇️
unit 30.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge December 1, 2023 12:24
@AlekSi AlekSi merged commit 4dbe2f4 into FerretDB:main Dec 1, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the hack-linter branch December 1, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @noisersup