Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commoncommands package #3780

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Remove commoncommands package #3780

merged 8 commits into from
Dec 1, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 29, 2023 •
edited
Loading

Description

Closes #3662.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #3780 (aaa81b6) into main (38e0d3d) will decrease coverage by 0.10%.
The diff coverage is 74.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3780      +/-   ##
==========================================
- Coverage   76.33%   76.23%   -0.10%     
==========================================
  Files         323      315       -8     
  Lines       23520    23506      -14     
==========================================
- Hits        17953    17920      -33     
- Misses       4525     4541      +16     
- Partials     1042     1045       +3
Files Coverage Δ
internal/handler/msg_buildinfo.go 100.00% <100.00%> (ø)
internal/handler/msg_connectionstatus.go 100.00% <100.00%> (ø)
internal/handler/msg_currentop.go 100.00% <100.00%> (ø)
internal/handler/msg_logout.go 100.00% <100.00%> (ø)
internal/handler/msg_whatsmyuri.go 100.00% <100.00%> (ø)
internal/handler/msg_getcmdlineopts.go 0.00% <0.00%> (ø)
internal/handler/msg_hostinfo.go 80.30% <80.00%> (-19.70%) ⬇️
internal/handler/msg_debugerror.go 25.00% <22.58%> (-75.00%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.38% <73.07%> (-0.10%) ⬇️
hana-1 ?
integration 72.38% <73.07%> (-0.10%) ⬇️
mongodb-1 5.36% <0.00%> (+<0.01%) ⬆️
postgresql-1 51.36% <29.67%> (-0.01%) ⬇️
postgresql-2 52.76% <31.86%> (+0.01%) ⬆️
postgresql-3 52.20% <58.79%> (+<0.01%) ⬆️
sqlite-1 50.60% <29.67%> (-0.01%) ⬇️
sqlite-2 51.91% <31.86%> (-0.01%) ⬇️
sqlite-3 51.26% <58.79%> (+0.02%) ⬆️
unit 30.73% <7.69%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup force-pushed the remove-commoncommands-3662 branch from ec9699d to 5389d76 Compare November 30, 2023 00:33
@noisersup noisersup added the code/chore Code maintenance improvements label Nov 30, 2023
@noisersup noisersup marked this pull request as ready for review November 30, 2023 00:39
@noisersup noisersup requested a review from a team as a code owner November 30, 2023 00:39
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and henvic November 30, 2023 00:39
AlekSi
AlekSi reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails. Also, Sprint and Milestone are not set, and auto-merge is not enabled.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Nov 30, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Nov 30, 2023
@noisersup noisersup added this to the Next milestone Nov 30, 2023
@noisersup noisersup requested a review from AlekSi November 30, 2023 10:31
@noisersup noisersup enabled auto-merge (squash) November 30, 2023 10:31
@noisersup noisersup changed the title Remove commoncommands Remove commoncommands Nov 30, 2023
@noisersup noisersup changed the title Remove commoncommands Remove commoncommands package Nov 30, 2023
@AlekSi AlekSi disabled auto-merge December 1, 2023 09:42
@AlekSi AlekSi merged commit e073f9d into FerretDB:main Dec 1, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Move and rename the handler
3 participants
@noisersup @AlekSi @henvic