Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stubs for authentication commands #3776

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Add stubs for authentication commands #3776

merged 11 commits into from
Dec 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 29, 2023 •
edited
Loading

Description

Plus make listCommands output dynamic.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 29, 2023
@AlekSi AlekSi changed the title Auth stubs Add stubs for authentication commands Nov 29, 2023
@mergify mergify bot assigned AlekSi Nov 29, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Nov 29, 2023
@AlekSi AlekSi added this to the Next milestone Nov 29, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #3776 (8b24a69) into main (8ebe4c2) will increase coverage by 0.00%.
The diff coverage is 79.25%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3776    +/-   ##
========================================
  Coverage   76.29%   76.30%            
========================================
  Files         318      324     +6     
  Lines       23153    23411   +258     
========================================
+ Hits        17664    17863   +199     
- Misses       4452     4511    +59     
  Partials     1037     1037
Files Coverage Δ
integration/setup/listener.go 70.65% <100.00%> (-3.12%) ⬇️
internal/clientconn/conn.go 55.49% <100.00%> (ø)
internal/handler/handler.go 73.91% <100.00%> (+5.49%) ⬆️
internal/handler/msg_listcommands.go 100.00% <100.00%> (ø)
internal/handler/registry/postgresql.go 77.77% <100.00%> (+0.85%) ⬆️
internal/handler/registry/registry.go 43.47% <ø> (ø)
internal/handler/registry/sqlite.go 77.77% <100.00%> (+0.85%) ⬆️
internal/handler/registry/hana.go 3.44% <0.00%> (-39.41%) ⬇️
internal/handler/registry/mysql.go 3.70% <0.00%> (-0.15%) ⬇️
internal/handler/msg_createuser.go 0.00% <0.00%> (ø)
... and 5 more

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.40% <79.25%> (+0.15%) ⬆️
hana-1 ?
integration 72.40% <79.25%> (+0.15%) ⬆️
mongodb-1 5.38% <0.00%> (-0.09%) ⬇️
postgresql-1 51.29% <78.88%> (+0.30%) ⬆️
postgresql-2 52.81% <78.14%> (+0.28%) ⬆️
postgresql-3 52.12% <78.14%> (+0.28%) ⬆️
sqlite-1 50.57% <78.88%> (?)
sqlite-2 51.91% <78.14%> (+0.35%) ⬆️
sqlite-3 51.24% <78.14%> (+0.30%) ⬆️
unit 30.75% <76.57%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review November 30, 2023 15:56
@AlekSi AlekSi requested a review from a team as a code owner November 30, 2023 15:56
@AlekSi AlekSi requested a review from rumyantseva November 30, 2023 15:56
@AlekSi AlekSi enabled auto-merge (squash) November 30, 2023 15:56
@AlekSi AlekSi requested review from a team, henvic and noisersup November 30, 2023 15:56
@AlekSi AlekSi disabled auto-merge December 1, 2023 05:06
@AlekSi AlekSi merged commit 4992933 into FerretDB:main Dec 1, 2023
30 of 31 checks passed
@AlekSi AlekSi deleted the auth-stubs branch December 1, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @noisersup