Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow system. prefix for collections for now #3775

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Allow system. prefix for collections for now #3775

merged 1 commit into from
Nov 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 29, 2023

Description

That will change once we have authorization.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi enabled auto-merge (squash) November 29, 2023 08:31
@AlekSi AlekSi added this to the Next milestone Nov 29, 2023
@AlekSi AlekSi self-assigned this Nov 29, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 29, 2023
@AlekSi AlekSi requested review from a team, henvic, rumyantseva and noisersup November 29, 2023 08:31
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #3775 (45c4844) into main (d09f9cd) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
- Coverage   76.74%   76.62%   -0.13%     
==========================================
  Files         316      316              
  Lines       23043    23043              
==========================================
- Hits        17685    17657      -28     
- Misses       4332     4356      +24     
- Partials     1026     1030       +4
Files Coverage Δ
internal/backends/validation.go 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.67% <100.00%> (-0.08%) ⬇️
hana-1 ?
integration 72.67% <100.00%> (-0.13%) ⬇️
mongodb-1 5.49% <0.00%> (ø)
postgresql-1 51.19% <100.00%> (-0.04%) ⬇️
postgresql-2 52.62% <0.00%> (-0.15%) ⬇️
postgresql-3 52.02% <0.00%> (-0.13%) ⬇️
sqlite-1 50.46% <100.00%> (-0.03%) ⬇️
sqlite-2 51.76% <0.00%> (-0.15%) ⬇️
sqlite-3 51.20% <0.00%> (-0.02%) ⬇️
unit 30.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

henvic
henvic approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@henvic henvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving it as the code looks fine and it seems to be safe to do so, but without context about the change of behavior per se.

@AlekSi AlekSi merged commit 491f4c5 into FerretDB:main Nov 29, 2023
30 checks passed
@AlekSi AlekSi deleted the system branch November 29, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @henvic @noisersup