Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TODOs #3771

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add TODOs #3771

merged 2 commits into from
Nov 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 28, 2023 •
edited
Loading

Description

Plus small cleanups.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 28, 2023
@AlekSi AlekSi mentioned this pull request Nov 28, 2023
Closed
@AlekSi AlekSi marked this pull request as ready for review November 28, 2023 14:37
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners November 28, 2023 14:37
@AlekSi AlekSi requested a review from rumyantseva November 28, 2023 14:37
@AlekSi AlekSi enabled auto-merge (squash) November 28, 2023 14:37
@AlekSi AlekSi requested review from a team and noisersup November 28, 2023 14:38
@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements labels Nov 28, 2023
@AlekSi AlekSi added this to the Next milestone Nov 28, 2023
@AlekSi AlekSi removed the documentation Something user-visible is badly or not documented label Nov 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #3771 (158b8a5) into main (0e22913) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3771      +/-   ##
==========================================
- Coverage   76.66%   76.62%   -0.05%     
==========================================
  Files         316      316              
  Lines       23037    23043       +6     
==========================================
- Hits        17662    17656       -6     
- Misses       4344     4357      +13     
+ Partials     1031     1030       -1
Files Coverage Δ
internal/handler/msg_listcollections.go 64.70% <100.00%> (+1.62%) ⬆️
internal/handler/msg_listdatabases.go 70.51% <100.00%> (+1.17%) ⬆️

... and 5 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.66% <100.00%> (-0.05%) ⬇️
hana-1 ?
integration 72.66% <100.00%> (-0.05%) ⬇️
mongodb-1 5.49% <0.00%> (-0.01%) ⬇️
postgresql-1 51.18% <100.00%> (-0.70%) ⬇️
postgresql-2 52.73% <100.00%> (+1.19%) ⬆️
postgresql-3 52.03% <100.00%> (-0.67%) ⬇️
sqlite-1 50.46% <100.00%> (-0.56%) ⬇️
sqlite-2 51.76% <100.00%> (+1.06%) ⬆️
sqlite-3 51.15% <100.00%> (-0.61%) ⬇️
unit 30.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup mentioned this pull request Nov 28, 2023
Merged
9 tasks
@AlekSi AlekSi disabled auto-merge November 28, 2023 15:02
@AlekSi AlekSi merged commit d09f9cd into FerretDB:main Nov 28, 2023
46 of 57 checks passed
@AlekSi AlekSi deleted the auth branch November 28, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @noisersup