Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TODOs #3764

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Add TODOs #3764

merged 5 commits into from
Nov 27, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 27, 2023 •
edited
Loading

Description

See #3601.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Nov 27, 2023
@AlekSi AlekSi added this to the Next milestone Nov 27, 2023
@AlekSi AlekSi self-assigned this Nov 27, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 27, 2023
@AlekSi AlekSi marked this pull request as ready for review November 27, 2023 13:31
@AlekSi AlekSi requested a review from a team as a code owner November 27, 2023 13:31
@AlekSi AlekSi requested a review from rumyantseva November 27, 2023 13:31
@AlekSi AlekSi enabled auto-merge (squash) November 27, 2023 13:31
@AlekSi AlekSi requested review from a team and noisersup November 27, 2023 13:31
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #3764 (287b959) into main (f4dd136) will decrease coverage by 5.86%.
The diff coverage is 55.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3764      +/-   ##
==========================================
- Coverage   76.58%   70.72%   -5.86%     
==========================================
  Files         324      324              
  Lines       23090    23096       +6     
==========================================
- Hits        17683    16335    -1348     
- Misses       4376     5637    +1261     
- Partials     1031     1124      +93
Files Coverage Δ
internal/handler/commonerrors/error.go 64.70% <ø> (-23.53%) ⬇️
internal/handler/msg_find.go 77.24% <91.66%> (-5.08%) ⬇️
internal/backends/backend.go 82.25% <0.00%> (-5.68%) ⬇️
internal/backends/database.go 92.20% <0.00%> (-5.06%) ⬇️

... and 76 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.01% <55.00%> (-6.62%) ⬇️
hana-1 ?
integration 66.01% <55.00%> (-6.62%) ⬇️
mongodb-1 5.48% <0.00%> (-0.01%) ⬇️
postgresql-1 51.80% <0.00%> (-0.02%) ⬇️
postgresql-2 ?
postgresql-3 ?
sqlite-1 50.90% <0.00%> (-0.11%) ⬇️
sqlite-2 ?
sqlite-3 51.73% <55.00%> (-0.08%) ⬇️
unit 30.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to having this implemented! 🚀

@AlekSi AlekSi disabled auto-merge November 27, 2023 15:02
@AlekSi AlekSi merged commit 1a93e47 into FerretDB:main Nov 27, 2023
24 of 29 checks passed
@AlekSi AlekSi deleted the list-by-name branch November 27, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva left review comments

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva