Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up old code for multiple handlers #3763

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Clean-up old code for multiple handlers #3763

merged 4 commits into from
Nov 27, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 27, 2023 •
edited
Loading

Description

Plus other small cleanups.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 27, 2023
@AlekSi AlekSi changed the title Handlers backends Clean-up old code for multiple handlers Nov 27, 2023
@mergify mergify bot assigned AlekSi Nov 27, 2023
@AlekSi AlekSi added this to the Next milestone Nov 27, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 27, 2023
@AlekSi AlekSi marked this pull request as ready for review November 27, 2023 12:20
@AlekSi AlekSi requested a review from a team as a code owner November 27, 2023 12:20
@AlekSi AlekSi requested a review from rumyantseva November 27, 2023 12:20
@AlekSi AlekSi enabled auto-merge (squash) November 27, 2023 12:20
@AlekSi AlekSi requested review from a team and noisersup November 27, 2023 12:20
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #3763 (1024fff) into main (364907c) will decrease coverage by 0.09%.
The diff coverage is 93.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
- Coverage   76.53%   76.44%   -0.09%     
==========================================
  Files         324      324              
  Lines       23090    23090              
==========================================
- Hits        17671    17652      -19     
- Misses       4384     4402      +18     
- Partials     1035     1036       +1
Files Coverage Δ
...rnal/handler/common/aggregations/operators/expr.go 76.81% <ø> (ø)
.../common/aggregations/operators/operators_errors.go 100.00% <ø> (ø)
...ernal/handler/common/aggregations/operators/sum.go 95.94% <ø> (ø)
internal/handler/common/client_metadata.go 100.00% <ø> (ø)
internal/handler/commonerrors/error.go 88.23% <ø> (ø)
internal/handler/registry/registry.go 43.47% <ø> (ø)
internal/types/document.go 96.07% <ø> (ø)
internal/handler/commonparams/commonparams.go 93.66% <93.66%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.49% <93.66%> (-0.09%) ⬇️
hana-1 ?
integration 72.49% <93.66%> (-0.09%) ⬇️
mongodb-1 5.48% <0.00%> (ø)
postgresql-1 51.80% <64.08%> (-0.08%) ⬇️
postgresql-2 51.45% <66.90%> (ø)
postgresql-3 52.63% <82.39%> (-0.04%) ⬇️
sqlite-1 50.92% <64.08%> (ø)
sqlite-2 50.61% <66.90%> (ø)
sqlite-3 51.80% <82.39%> (+0.17%) ⬆️
unit 30.26% <45.07%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlekSi AlekSi disabled auto-merge November 27, 2023 13:27
@AlekSi AlekSi merged commit f4dd136 into FerretDB:main Nov 27, 2023
46 of 49 checks passed
@AlekSi AlekSi deleted the handlers-backends branch November 27, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva