Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup MySQL integration tests #3758

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Nov 24, 2023

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@adetunjii adetunjii requested review from AlekSi and a team as code owners November 24, 2023 18:56
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #3758 (5757ba9) into main (491f4c5) will decrease coverage by 0.12%.
The diff coverage is 5.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
- Coverage   76.48%   76.37%   -0.12%     
==========================================
  Files         316      317       +1     
  Lines       23043    23117      +74     
==========================================
+ Hits        17625    17655      +30     
- Misses       4381     4429      +48     
+ Partials     1037     1033       -4     
Files Coverage Δ
integration/setup/setup.go 79.77% <ø> (ø)
integration/setup/listener.go 70.49% <28.57%> (-3.48%) ⬇️
internal/util/testutil/mysql.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.42% <5.40%> (-0.10%) ⬇️
integration 72.42% <5.40%> (-0.10%) ⬇️
mongodb-1 5.47% <0.00%> (-0.02%) ⬇️
postgresql-1 51.09% <4.05%> (-0.10%) ⬇️
postgresql-2 52.58% <4.05%> (-0.11%) ⬇️
postgresql-3 51.93% <4.05%> (-0.10%) ⬇️
sqlite-1 50.31% <4.05%> (-0.16%) ⬇️
sqlite-2 51.71% <4.05%> (?)
sqlite-3 51.02% <4.05%> (-0.16%) ⬇️
unit 30.24% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@adetunjii adetunjii force-pushed the feat/mysql-integration-setup branch from 28cc687 to 6b36ca9 Compare November 25, 2023 10:52
@AlekSi AlekSi added this to the Next milestone Nov 27, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 27, 2023
@AlekSi AlekSi enabled auto-merge (squash) November 27, 2023 08:51
go.mod Outdated Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
integration/setup/listener.go Show resolved Hide resolved
integration/setup/listener.go Show resolved Hide resolved
integration/setup/listener.go Outdated Show resolved Hide resolved
internal/util/testutil/mysql.go Show resolved Hide resolved
auto-merge was automatically disabled November 27, 2023 10:21

Head branch was pushed to by a user without write access

@adetunjii adetunjii requested a review from AlekSi November 27, 2023 10:57
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places where "mysql" should be before "hana"

@adetunjii adetunjii requested a review from AlekSi November 27, 2023 13:50
integration/setup/setup.go Outdated Show resolved Hide resolved
@AlekSi AlekSi requested review from AlekSi, a team and noisersup November 28, 2023 05:15
@AlekSi AlekSi enabled auto-merge (squash) November 28, 2023 05:15
@AlekSi AlekSi requested review from a team and henvic and removed request for a team November 29, 2023 06:33
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks good to me

@AlekSi AlekSi merged commit aad8a21 into FerretDB:main Nov 29, 2023
34 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants