Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sqlite/*.go to internal/handler #3755

Merged
merged 9 commits into from
Nov 25, 2023
Merged

Move sqlite/*.go to internal/handler #3755

merged 9 commits into from
Nov 25, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Nov 23, 2023 •
edited
Loading

Description

I updated everything I found relevant. Please let me know if you see any other places that need to be updated in the current PR.

Closes #3662.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #3755 (4643eb6) into main (a93ce53) will decrease coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   76.55%   76.41%   -0.14%     
==========================================
  Files         324      324              
  Lines       23090    23090              
==========================================
- Hits        17676    17644      -32     
- Misses       4381     4408      +27     
- Partials     1033     1038       +5
Files Coverage Δ
ferretdb/ferretdb.go 83.16% <ø> (ø)
integration/setup/listener.go 73.96% <ø> (-2.96%) ⬇️
internal/backends/postgresql/collection.go 74.13% <ø> (ø)
internal/backends/postgresql/insert.go 88.88% <ø> (ø)
internal/backends/postgresql/metadata/metadata.go 63.63% <ø> (ø)
internal/backends/postgresql/metadata/registry.go 70.21% <ø> (-0.47%) ⬇️
internal/backends/postgresql/query.go 92.11% <ø> (ø)
internal/backends/postgresql/query_iterator.go 87.80% <ø> (ø)
internal/backends/sqlite/collection.go 81.67% <ø> (ø)
internal/backends/sqlite/insert.go 88.46% <ø> (ø)
... and 154 more

... and 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.46% <ø> (-0.15%) ⬇️
hana-1 ?
integration 72.46% <ø> (-0.15%) ⬇️
mongodb-1 5.48% <ø> (ø)
postgresql-1 51.82% <ø> (+0.01%) ⬆️
postgresql-2 51.45% <ø> (ø)
postgresql-3 52.52% <ø> (-0.16%) ⬇️
sqlite-1 50.91% <ø> (-0.01%) ⬇️
sqlite-2 50.61% <ø> (ø)
sqlite-3 51.64% <ø> (-0.16%) ⬇️
unit 30.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title Rename internal/handlers and move sqlite/*.go Move sqlite/*.go to internal/handler Nov 23, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Nov 23, 2023
@rumyantseva rumyantseva added this to the Next milestone Nov 23, 2023
rumyantseva
rumyantseva commented Nov 23, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@rumyantseva rumyantseva marked this pull request as ready for review November 23, 2023 23:31
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners November 23, 2023 23:31
@rumyantseva rumyantseva requested review from a team and noisersup November 23, 2023 23:31
@rumyantseva rumyantseva enabled auto-merge (squash) November 23, 2023 23:37
noisersup
noisersup previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from above no changes needed! LGTM

@rumyantseva rumyantseva merged commit 2664b9a into FerretDB:main Nov 25, 2023
27 of 28 checks passed
@rumyantseva rumyantseva deleted the issue-3662-rename-handler branch November 25, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Move and rename the handler
3 participants
@rumyantseva @AlekSi @noisersup