Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide sort to backend as the document #3754

Merged
merged 49 commits into from
Nov 30, 2023
Merged

Provide sort to backend as the document #3754

merged 49 commits into from
Nov 30, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 23, 2023 •
edited
Loading

Description

Closes #3742.

As agreed:

  • This PR covers only query command. Let's discuss how we solve explain.
  • We don't use the pushdown result yet in handler.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Nov 23, 2023
@noisersup noisersup added the code/chore Code maintenance improvements label Nov 23, 2023
@noisersup noisersup added this to the Next milestone Nov 23, 2023
@noisersup noisersup added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #3754 (1339a39) into main (8ebe4c2) will decrease coverage by 0.07%.
The diff coverage is 79.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   76.29%   76.22%   -0.07%     
==========================================
  Files         318      318              
  Lines       23153    23264     +111     
==========================================
+ Hits        17664    17733      +69     
- Misses       4452     4489      +37     
- Partials     1037     1042       +5
Files Coverage Δ
internal/backends/postgresql/collection.go 74.07% <100.00%> (-0.06%) ⬇️
internal/backends/postgresql/query.go 92.27% <100.00%> (+0.15%) ⬆️
internal/backends/sqlite/collection.go 82.94% <ø> (+2.79%) ⬆️
internal/backends/sqlite/query.go 100.00% <100.00%> (ø)
internal/handler/msg_aggregate.go 87.83% <100.00%> (+0.51%) ⬆️
internal/handler/msg_find.go 78.98% <100.00%> (-3.09%) ⬇️
internal/handler/common/sort.go 84.13% <82.60%> (-4.44%) ⬇️
internal/backends/collection.go 92.62% <73.52%> (-7.38%) ⬇️
internal/handler/msg_explain.go 61.36% <23.07%> (-6.64%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.33% <76.86%> (+0.08%) ⬆️
hana-1 ?
integration 72.33% <76.86%> (+0.08%) ⬆️
mongodb-1 5.44% <0.00%> (-0.03%) ⬇️
postgresql-1 51.06% <66.41%> (+0.07%) ⬆️
postgresql-2 52.37% <67.91%> (-0.17%) ⬇️
postgresql-3 51.85% <48.50%> (+<0.01%) ⬆️
sqlite-1 50.29% <60.44%> (?)
sqlite-2 51.62% <62.68%> (+0.07%) ⬆️
sqlite-3 50.92% <43.28%> (-0.02%) ⬇️
unit 30.17% <27.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Nov 27, 2023
@noisersup noisersup removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 27, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Nov 27, 2023
@noisersup noisersup force-pushed the return-sort-pushdown-info-3742 branch from 7b72a5f to b2f6280 Compare November 29, 2023 17:58
@noisersup noisersup requested review from AlekSi, a team and henvic November 30, 2023 01:09
@AlekSi AlekSi self-requested a review November 30, 2023 10:10
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Nov 30, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Nov 30, 2023
@noisersup noisersup requested a review from AlekSi November 30, 2023 15:40
@noisersup noisersup changed the title Return information about sort pushdown for find and aggregate Provide sort to backend as the document Nov 30, 2023
@noisersup noisersup merged commit 9c42561 into FerretDB:main Nov 30, 2023
28 checks passed
@noisersup noisersup deleted the return-sort-pushdown-info-3742 branch November 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henvic henvic henvic approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Return information about sort pushdown
3 participants
@noisersup @AlekSi @henvic