Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe pushdown #3752

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Remove unsafe pushdown #3752

merged 6 commits into from
Nov 23, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 23, 2023 •
edited
Loading

Description

Closes #3741.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #3752 (ccbe8da) into main (e60e99b) will increase coverage by 0.17%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
+ Coverage   76.21%   76.39%   +0.17%     
==========================================
  Files         324      324              
  Lines       23116    23060      -56     
==========================================
- Hits        17618    17616       -2     
+ Misses       4453     4406      -47     
+ Partials     1045     1038       -7
Files Coverage Δ
integration/pushdown.go 68.18% <100.00%> (-3.82%) ⬇️
integration/setup/listener.go 73.96% <100.00%> (-3.10%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
integration/setup/test_helpers.go 100.00% <ø> (+25.00%) ⬆️
internal/handlers/registry/postgresql.go 76.92% <100.00%> (-0.86%) ⬇️
internal/handlers/registry/registry.go 43.47% <ø> (ø)
internal/handlers/registry/sqlite.go 76.92% <100.00%> (-0.86%) ⬇️
internal/handlers/sqlite/msg_aggregate.go 87.32% <100.00%> (+3.54%) ⬆️
internal/handlers/sqlite/msg_explain.go 68.00% <100.00%> (+9.30%) ⬆️
internal/handlers/sqlite/msg_find.go 82.31% <100.00%> (+7.15%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.54% <71.42%> (+0.16%) ⬆️
hana-1 ?
integration 72.54% <71.42%> (+0.16%) ⬆️
mongodb-1 5.49% <0.00%> (?)
postgresql-1 51.87% <57.14%> (+0.09%) ⬆️
postgresql-2 51.49% <50.00%> (+0.09%) ⬆️
postgresql-3 52.61% <50.00%> (+0.05%) ⬆️
sqlite-1 50.97% <57.14%> (+0.08%) ⬆️
sqlite-2 50.65% <50.00%> (+0.10%) ⬆️
sqlite-3 51.68% <50.00%> (+0.11%) ⬆️
unit 30.20% <18.18%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/chore Code maintenance improvements label Nov 23, 2023
@noisersup noisersup added this to the Next milestone Nov 23, 2023
@noisersup noisersup marked this pull request as ready for review November 23, 2023 12:26
@noisersup noisersup requested a review from a team as a code owner November 23, 2023 12:26
@noisersup noisersup enabled auto-merge (squash) November 23, 2023 12:27
rumyantseva
rumyantseva approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noisersup noisersup merged commit 75ebdfb into FerretDB:main Nov 23, 2023
28 checks passed
@noisersup noisersup deleted the remove-unsafe-pushdown-3741 branch November 23, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Remove unsafe pushdowns
3 participants
@noisersup @AlekSi @rumyantseva