Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RecordID a signed value #3740

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Make RecordID a signed value #3740

merged 4 commits into from
Nov 23, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 23, 2023 •
edited
Loading

Description

Plus a few TODOs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #3740 (530bd91) into main (cbec9f8) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
- Coverage   76.95%   76.41%   -0.54%     
==========================================
  Files         323      323              
  Lines       23070    23069       -1     
==========================================
- Hits        17753    17629     -124     
- Misses       4291     4402     +111     
- Partials     1026     1038      +12
Files Coverage Δ
internal/backends/collection.go 100.00% <100.00%> (ø)
internal/backends/postgresql/query_iterator.go 87.80% <100.00%> (ø)
internal/backends/sqlite/query_iterator.go 82.92% <100.00%> (ø)
internal/handlers/sqlite/msg_explain.go 58.69% <ø> (-15.22%) ⬇️
internal/handlers/sqlite/msg_find.go 75.15% <100.00%> (-11.10%) ⬇️
internal/types/document.go 96.07% <100.00%> (ø)
internal/types/timestamp.go 100.00% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.57% <100.00%> (-0.58%) ⬇️
hana-1 ?
integration 72.57% <100.00%> (-0.61%) ⬇️
mongodb-1 5.45% <0.00%> (+<0.01%) ⬆️
postgresql-1 51.90% <92.30%> (-0.23%) ⬇️
postgresql-2 51.48% <92.30%> (-0.28%) ⬇️
postgresql-3 52.52% <92.30%> (-0.43%) ⬇️
sort-false 72.57% <100.00%> (-0.14%) ⬇️
sort-true ?
sqlite-1 50.99% <92.30%> (-0.25%) ⬇️
sqlite-2 50.63% <92.30%> (-0.20%) ⬇️
sqlite-3 51.81% <92.30%> (-0.53%) ⬇️
unit 30.16% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review November 23, 2023 04:39
@AlekSi AlekSi requested a review from a team as a code owner November 23, 2023 04:39
@AlekSi AlekSi requested a review from rumyantseva November 23, 2023 04:39
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 23, 2023
@AlekSi AlekSi added this to the Next milestone Nov 23, 2023
@AlekSi AlekSi requested review from a team and noisersup November 23, 2023 04:42
@AlekSi AlekSi enabled auto-merge (squash) November 23, 2023 04:42
@AlekSi AlekSi mentioned this pull request Nov 23, 2023
Merged
9 tasks
rumyantseva
rumyantseva approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge November 23, 2023 07:37
@AlekSi AlekSi merged commit dc76d33 into FerretDB:main Nov 23, 2023
30 of 36 checks passed
@AlekSi AlekSi deleted the timestamp branch November 23, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva