Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small assorted tweaks #3724

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Small assorted tweaks #3724

merged 1 commit into from
Nov 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 17, 2023 •
edited
Loading

Description

Extracted from other PRs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 17, 2023
@AlekSi AlekSi added this to the Next milestone Nov 17, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 17, 2023
@AlekSi AlekSi marked this pull request as ready for review November 17, 2023 13:03
@AlekSi AlekSi enabled auto-merge (squash) November 17, 2023 13:03
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup November 17, 2023 13:03
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Merging #3724 (0e1f559) into main (d96606c) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
- Coverage   76.48%   76.43%   -0.06%     
==========================================
  Files         323      323              
  Lines       23069    23069              
==========================================
- Hits        17645    17633      -12     
- Misses       4387     4400      +13     
+ Partials     1037     1036       -1
Files Coverage Δ
internal/backends/decorators/dummy/backend.go 0.00% <ø> (ø)
internal/backends/decorators/dummy/collection.go 0.00% <ø> (ø)
internal/backends/decorators/dummy/database.go 0.00% <ø> (ø)
internal/backends/decorators/oplog/backend.go 73.91% <ø> (ø)
internal/backends/decorators/oplog/collection.go 35.55% <ø> (ø)
internal/backends/decorators/oplog/database.go 100.00% <ø> (ø)
internal/backends/hana/backend.go 0.00% <ø> (-15.39%) ⬇️
internal/backends/postgresql/backend.go 64.10% <ø> (ø)
internal/backends/sqlite/backend.go 77.96% <ø> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.57% <ø> (-0.06%) ⬇️
hana-1 ?
integration 72.57% <ø> (-0.06%) ⬇️
mongodb-1 5.45% <ø> (ø)
postgresql-1 51.82% <ø> (-0.02%) ⬇️
postgresql-2 51.50% <ø> (ø)
postgresql-3 52.56% <ø> (-0.06%) ⬇️
sort-false 72.57% <ø> (-0.06%) ⬇️
sqlite-1 50.97% <ø> (+0.03%) ⬆️
sqlite-2 50.66% <ø> (ø)
sqlite-3 51.64% <ø> (-0.06%) ⬇️
unit 30.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see a label for performance!

@AlekSi AlekSi merged commit 925e739 into FerretDB:main Nov 17, 2023
28 of 30 checks passed
@AlekSi AlekSi deleted the small-tweaks branch November 17, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup