Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DeleteAll for capped collections #3718

Merged
merged 23 commits into from
Nov 23, 2023
Merged

Support DeleteAll for capped collections #3718

merged 23 commits into from
Nov 23, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Nov 15, 2023 •
edited
Loading

Description

Closes #3498.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Nov 15, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Nov 15, 2023
@rumyantseva rumyantseva added this to the Next milestone Nov 15, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Merging #3718 (4727352) into main (75ebdfb) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3718      +/-   ##
==========================================
- Coverage   76.38%   76.35%   -0.03%     
==========================================
  Files         324      324              
  Lines       23060    23087      +27     
==========================================
+ Hits        17614    17628      +14     
- Misses       4410     4422      +12     
- Partials     1036     1037       +1
Files Coverage Δ
internal/backends/postgresql/collection.go 74.13% <100.00%> (+4.20%) ⬆️
internal/backends/sqlite/collection.go 79.64% <100.00%> (-1.41%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.27% <63.04%> (-0.08%) ⬇️
hana-1 ?
integration 72.27% <63.04%> (-0.08%) ⬇️
mongodb-1 5.48% <0.00%> (-0.01%) ⬇️
postgresql-1 51.87% <32.60%> (+0.01%) ⬆️
postgresql-2 51.46% <32.60%> (?)
postgresql-3 52.56% <32.60%> (-0.05%) ⬇️
sqlite-1 50.96% <30.43%> (-0.05%) ⬇️
sqlite-2 ?
sqlite-3 51.80% <30.43%> (+0.07%) ⬆️
unit 30.31% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review November 15, 2023 19:03
@rumyantseva rumyantseva requested a review from AlekSi as a code owner November 15, 2023 19:03
@rumyantseva rumyantseva enabled auto-merge (squash) November 15, 2023 19:03
@rumyantseva rumyantseva requested review from a team and noisersup November 15, 2023 19:03
@rumyantseva rumyantseva requested a review from AlekSi November 16, 2023 21:54
AlekSi
AlekSi reviewed Nov 17, 2023
View reviewed changes
internal/backends/collection_test.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from AlekSi November 17, 2023 16:28
noisersup
noisersup previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving pre-approval as most of the things look ready to me, but there's still some investigation about edge case value

internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
@AlekSi AlekSi modified the milestone: Next Nov 20, 2023
AlekSi
AlekSi reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3740

AlekSi
AlekSi requested changes Nov 23, 2023
View reviewed changes
internal/backends/helpers_test.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from AlekSi November 23, 2023 13:35
@AlekSi AlekSi requested review from a team November 23, 2023 13:39
@rumyantseva rumyantseva requested a review from AlekSi November 23, 2023 14:52
noisersup
noisersup approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rumyantseva rumyantseva merged commit 7936b3a into FerretDB:main Nov 23, 2023
27 checks passed
@rumyantseva rumyantseva deleted the issue-3498-delete-all branch November 23, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Support DeleteAll for capped collections
3 participants
@rumyantseva @AlekSi @noisersup