Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle panicking tests #3711

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Handle panicking tests #3711

merged 2 commits into from
Nov 15, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 14, 2023 •
edited
Loading

Description

Stack traces are no longer hidden.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 14, 2023
@AlekSi AlekSi marked this pull request as ready for review November 14, 2023 19:22
@AlekSi AlekSi requested a review from a team as a code owner November 14, 2023 19:22
@AlekSi AlekSi requested a review from rumyantseva November 14, 2023 19:22
@AlekSi AlekSi enabled auto-merge (squash) November 14, 2023 19:22
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 14, 2023
@AlekSi AlekSi added this to the Next milestone Nov 14, 2023
@AlekSi AlekSi requested review from a team and noisersup November 14, 2023 19:22
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Merging #3711 (0c7a403) into main (74009c0) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   76.38%   76.23%   -0.15%     
==========================================
  Files         323      323              
  Lines       23029    23029              
==========================================
- Hits        17591    17557      -34     
- Misses       4402     4434      +32     
- Partials     1036     1038       +2

see 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.27% <ø> (-0.15%) ⬇️
hana-1 ?
integration 72.27% <ø> (-0.15%) ⬇️
mongodb-1 5.46% <ø> (ø)
postgresql-1 52.51% <ø> (+0.16%) ⬆️
postgresql-2 51.63% <ø> (-0.01%) ⬇️
postgresql-3 50.69% <ø> (ø)
sort-false 72.27% <ø> (-0.15%) ⬇️
sqlite-1 51.68% <ø> (ø)
sqlite-2 50.86% <ø> (-0.04%) ⬇️
sqlite-3 49.90% <ø> (ø)
unit 30.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

noisersup
noisersup approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi disabled auto-merge November 15, 2023 05:03
@AlekSi AlekSi merged commit 7d5c3f2 into FerretDB:main Nov 15, 2023
27 checks passed
@AlekSi AlekSi deleted the panics branch November 15, 2023 05:03
rumyantseva
rumyantseva approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@AlekSi @yonarw
Handle panicking tests (FerretDB#3711)
261e558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup