Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate SQL queries with comments for find operations #3697

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Generate SQL queries with comments for find operations #3697

merged 10 commits into from
Nov 17, 2023

Conversation

chumaumenze
Copy link
Contributor

@chumaumenze chumaumenze commented Nov 10, 2023 •
edited by noisersup
Loading

Description

Closes #3573.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chumaumenze chumaumenze requested a review from AlekSi as a code owner November 10, 2023 16:05
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlekSi
Copy link
Member

AlekSi commented Nov 10, 2023

@chumaumenze please leave a comment on #3573 so we could assign the issue

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #3697 (78f08bd) into main (532787d) will decrease coverage by 0.58%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   76.75%   76.17%   -0.58%     
==========================================
  Files         323      323              
  Lines       23035    23063      +28     
==========================================
- Hits        17680    17569     -111     
- Misses       4326     4448     +122     
- Partials     1029     1046      +17
Files Coverage Δ
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/postgresql/collection.go 72.18% <100.00%> (+0.82%) ⬆️
internal/backends/sqlite/collection.go 80.15% <100.00%> (-0.80%) ⬇️
internal/backends/sqlite/query.go 100.00% <100.00%> (ø)
internal/backends/postgresql/query.go 92.11% <85.00%> (-1.12%) ⬇️

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.20% <82.22%> (-0.63%) ⬇️
hana-1 ?
integration 72.20% <82.22%> (-0.65%) ⬇️
mongodb-1 5.46% <0.00%> (-0.01%) ⬇️
postgresql-1 52.34% <48.88%> (-0.39%) ⬇️
postgresql-2 51.65% <60.00%> (-0.27%) ⬇️
postgresql-3 50.70% <51.11%> (-0.23%) ⬇️
sort-false 72.20% <82.22%> (-0.18%) ⬇️
sort-true ?
sqlite-1 51.53% <11.11%> (-0.70%) ⬇️
sqlite-2 50.78% <22.22%> (-0.31%) ⬇️
sqlite-3 49.82% <20.00%> (-0.24%) ⬇️
unit 30.16% <93.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from noisersup November 10, 2023 16:12
@AlekSi AlekSi added this to the Next milestone Nov 10, 2023
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Nov 10, 2023
@AlekSi
Copy link
Member

AlekSi commented Nov 10, 2023

@chumaumenze

FerretDB/CONTRIBUTING.md

Line 365 in 1f18df0

so there is **no need** to squash them manually, amend them, and/or do force pushes.

It makes our review process harder

noisersup
noisersup reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Most of the things look great, just small tweaks from me.

internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
internal/backends/postgresql/query_test.go Outdated Show resolved Hide resolved
noisersup
noisersup previously approved these changes Nov 16, 2023
View reviewed changes
@noisersup noisersup self-requested a review November 16, 2023 13:44
@noisersup noisersup enabled auto-merge (squash) November 16, 2023 14:42
@noisersup noisersup merged commit 05fb806 into FerretDB:main Nov 17, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@chumaumenze chumaumenze

@noisersup noisersup

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Generate queries with comments
4 participants
@chumaumenze @CLAassistant @AlekSi @noisersup