Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pushdown terminology #3691

Merged
merged 31 commits into from
Nov 20, 2023
Merged

Cleanup pushdown terminology #3691

merged 31 commits into from
Nov 20, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 9, 2023 •
edited
Loading

Description

Closes #3688.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Nov 9, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #3691 (8416137) into main (23103e2) will decrease coverage by 5.79%.
The diff coverage is 93.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
- Coverage   76.53%   70.75%   -5.79%     
==========================================
  Files         323      323              
  Lines       23069    23070       +1     
==========================================
- Hits        17657    16324    -1333     
- Misses       4377     5641    +1264     
- Partials     1035     1105      +70
Files Coverage Δ
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/postgresql/collection.go 72.55% <100.00%> (ø)
internal/backends/sqlite/collection.go 80.26% <100.00%> (ø)
internal/handlers/sqlite/msg_explain.go 58.69% <100.00%> (ø)
internal/handlers/sqlite/msg_aggregate.go 73.24% <0.00%> (-10.77%) ⬇️

... and 58 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.41% <93.75%> (-6.27%) ⬇️
hana-1 ?
integration 66.41% <93.75%> (-6.27%) ⬇️
mongodb-1 5.45% <0.00%> (-0.01%) ⬇️
postgresql-1 51.85% <37.50%> (+0.02%) ⬆️
postgresql-2 51.46% <31.25%> (-0.05%) ⬇️
postgresql-3 ?
sort-false 66.41% <93.75%> (-6.27%) ⬇️
sqlite-1 50.94% <75.00%> (-0.05%) ⬇️
sqlite-2 50.62% <68.75%> (-0.05%) ⬇️
sqlite-3 ?
unit 30.17% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup force-pushed the cleanup-pushdown-term-3688 branch from a75a1d9 to 15a2077 Compare November 15, 2023 09:07
@noisersup noisersup marked this pull request as ready for review November 15, 2023 19:16
@noisersup noisersup requested review from AlekSi, ptrfarkas and a team as code owners November 15, 2023 19:16
@noisersup noisersup added the code/chore Code maintenance improvements label Nov 15, 2023
@noisersup noisersup added this to the Next milestone Nov 15, 2023
@AlekSi AlekSi requested a review from a team November 16, 2023 05:20
@AlekSi AlekSi requested review from a team November 17, 2023 07:53
AlekSi
AlekSi requested changes Nov 17, 2023
View reviewed changes
integration/query_command_compat_test.go Outdated Show resolved Hide resolved
integration/query_test.go Outdated Show resolved Hide resolved
website/docs/reference/glossary.md Outdated Show resolved Hide resolved
website/docs/reference/glossary.md Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_explain.go Outdated Show resolved Hide resolved
rumyantseva
rumyantseva reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have my own questions about the PR (I agree with what Alexey asked).

rumyantseva
rumyantseva previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noisersup noisersup force-pushed the cleanup-pushdown-term-3688 branch from af147ea to 2852ea9 Compare November 17, 2023 15:43
@AlekSi AlekSi modified the milestone: Next Nov 20, 2023
@AlekSi AlekSi added do not merge PRs that should not be merged and removed do not merge PRs that should not be merged labels Nov 20, 2023
@AlekSi AlekSi merged commit c1dbb63 into FerretDB:main Nov 20, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Cleanup pushdown terminology
3 participants
@noisersup @AlekSi @rumyantseva