Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON format for logging #3689

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 8, 2023

Description

This PR also updates docs and cleanups some remnants of the old PostgreSQL backend.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI labels Nov 8, 2023
@AlekSi AlekSi added this to the Next milestone Nov 8, 2023
@AlekSi AlekSi self-assigned this Nov 8, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 8, 2023
@AlekSi AlekSi marked this pull request as ready for review November 8, 2023 16:45
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners November 8, 2023 16:45
@AlekSi AlekSi requested a review from rumyantseva November 8, 2023 16:45
@AlekSi AlekSi enabled auto-merge (squash) November 8, 2023 16:45
@AlekSi AlekSi requested review from a team, noisersup and Fashander November 8, 2023 16:45
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #3689 (2f9839c) into main (22421e7) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3689      +/-   ##
==========================================
- Coverage   76.40%   76.18%   -0.23%     
==========================================
  Files         321      321              
  Lines       22958    22969      +11     
==========================================
- Hits        17542    17499      -43     
- Misses       4387     4435      +48     
- Partials     1029     1035       +6     
Files Coverage Δ
ferretdb/ferretdb.go 82.65% <100.00%> (ø)
integration/setup/startup.go 64.10% <100.00%> (ø)
internal/util/debug/debug.go 89.47% <100.00%> (+1.23%) ⬆️
internal/util/logging/logging.go 81.25% <100.00%> (+1.25%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.96% <100.00%> (-0.42%) ⬇️
hana-1 ?
integration 71.96% <100.00%> (-0.42%) ⬇️
mongodb-1 5.48% <100.00%> (+0.04%) ⬆️
postgresql-1 52.57% <100.00%> (+0.02%) ⬆️
postgresql-2 50.45% <100.00%> (+0.02%) ⬆️
postgresql-3 ?
sort-false 71.96% <100.00%> (-0.42%) ⬇️
sqlite-1 51.88% <100.00%> (+0.02%) ⬆️
sqlite-2 49.77% <100.00%> (+0.02%) ⬆️
sqlite-3 50.87% <100.00%> (+0.02%) ⬆️
unit 29.92% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge November 9, 2023 04:23
@AlekSi AlekSi merged commit 8a18837 into FerretDB:main Nov 9, 2023
25 of 27 checks passed
@AlekSi AlekSi deleted the prometheus-metrics branch November 9, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants