Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blogpost for "How to Package and Deploy FerretDB with Acorn" #3679

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Add blogpost for "How to Package and Deploy FerretDB with Acorn" #3679

merged 12 commits into from
Nov 15, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Nov 6, 2023 •
edited
Loading

Description

Closes FerretDB/engineering#88

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the blog/marketing Marketing (and releases) blog posts label Nov 6, 2023
@Fashander Fashander added this to the Next milestone Nov 6, 2023
@Fashander Fashander requested a review from AlekSi as a code owner November 6, 2023 14:17
@Fashander Fashander self-assigned this Nov 6, 2023
@Fashander Fashander requested a review from ptrfarkas as a code owner November 6, 2023 14:17
@Fashander Fashander added the trust PRs that can access Actions secrets label Nov 6, 2023
@Fashander Fashander enabled auto-merge (squash) November 6, 2023 14:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #3679 (481b436) into main (7d5c3f2) will decrease coverage by 5.76%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3679      +/-   ##
==========================================
- Coverage   76.36%   70.60%   -5.76%     
==========================================
  Files         323      323              
  Lines       23029    23029              
==========================================
- Hits        17585    16259    -1326     
- Misses       4406     5656    +1250     
- Partials     1038     1114      +76

see 62 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.09% <ø> (-6.31%) ⬇️
hana-1 3.61% <ø> (ø)
integration 66.09% <ø> (-6.31%) ⬇️
mongodb-1 5.46% <ø> (ø)
postgresql-1 ?
postgresql-2 51.63% <ø> (-0.01%) ⬇️
postgresql-3 50.69% <ø> (ø)
sort-false 66.09% <ø> (-6.31%) ⬇️
sqlite-1 ?
sqlite-2 50.90% <ø> (+0.04%) ⬆️
sqlite-3 ?
unit 30.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now

@Fashander
Copy link
Member Author

@AlekSi This is ready for review now. PTAL

@Fashander Fashander requested a review from AlekSi November 10, 2023 11:14
ptrfarkas
ptrfarkas previously approved these changes Nov 15, 2023
View reviewed changes
@Fashander Fashander requested a review from ptrfarkas November 15, 2023 14:22
@AlekSi AlekSi disabled auto-merge November 15, 2023 14:27
@AlekSi AlekSi merged commit 5281e61 into FerretDB:main Nov 15, 2023
25 of 27 checks passed
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@Fashander @yonarw
Add blogpost for "How to Package and Deploy FerretDB with Acorn" (Fer…
8f5a324 
…retDB#3679)
@Fashander Fashander deleted the acorn-blog branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@Fashander Fashander

Labels
blog/marketing Marketing (and releases) blog posts trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Fashander @AlekSi @ptrfarkas